isisd, lib: add some codepoints usually shared with other vendors #17957
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjstapp
reviewed
Jan 29, 2025
lib/srv6.h
Outdated
| SRV6_ENDPOINT_BEHAVIOR_END_DT4_USID = 0x003F, | ||
| SRV6_ENDPOINT_BEHAVIOR_END_DT46_USID = 0x0040, | ||
| SRV6_ENDPOINT_BEHAVIOR_OPAQUE = 0xFFFF, | ||
| SRV6_ENDPOINT_BEHAVIOR_RESERVED = 0x0000, |
There was a problem hiding this comment.
It'd be better not to un-do the existing clear formatting?
There was a problem hiding this comment.
well, git clang will complain, no?
There was a problem hiding this comment.
clang is wrong about several things - like this.
the goal is clear, readable code - if clang is wrong, then ... it's wrong.
Some codepoints can not be read by interoperating with CISCO. This is because PSP/USP flavor are used by default, and the display of the isis output has to be adapted. Signed-off-by: Philippe Guibert <[email protected]>
pguibert6WIND
force-pushed
the
codepoint_add_some_flavors
branch
from
d39ae12 to
d95b65d
Compare
|
formatting looks fine - but there are compilation errors... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some codepoints can not be read by interoperating with CISCO. This is because PSP/USP flavor are used by default, and the display of the isis output has to be adapted.