try using narwhals to make dataframe-agnostic #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FBruzzesi
approved these changes
Apr 30, 2024
pyproject.toml
Outdated
Comment on lines
39
to
40
| polars = ["polars"] | ||
| pandas = ["pandas"] |
There was a problem hiding this comment.
Are there min versions required by narwhals? It seems it doesn't from pyproject.toml
There was a problem hiding this comment.
thanks!
I'll test this backwards and see how far we can get, but .filter I'd expect should go back essentially forever
There was a problem hiding this comment.
would pandas>=1.2.0 and Polars>=0.20.3 work for you? I've set those as the minimum, and have tested with the minimum versions
FBruzzesi
approved these changes
Apr 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #35
was curious to try this out - curious to hear your results (no offense / worries whatsoever if you don't want or like this!), tbh I think it looks quite neat