Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Limit number of sources in merged scan task #3695

Merged
merged 5 commits into from
Jan 30, 2025

test

a5b9f5e
Select commit
Loading
Failed to load commit list.
Merged

feat: Limit number of sources in merged scan task #3695

test
a5b9f5e
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jan 27, 2025 in 0s

77.04% (-0.81%) compared to 4b67e5a

View this Pull Request on Codecov

77.04% (-0.81%) compared to 4b67e5a

Details

Codecov Report

Attention: Patch coverage is 80.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 77.04%. Comparing base (4b67e5a) to head (a5b9f5e).
Report is 18 commits behind head on main.

Files with missing lines Patch % Lines
src/common/daft-config/src/python.rs 57.14% 3 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3695      +/-   ##
==========================================
- Coverage   77.84%   77.04%   -0.81%     
==========================================
  Files         732      729       -3     
  Lines       90605    92649    +2044     
==========================================
+ Hits        70534    71380     +846     
- Misses      20071    21269    +1198     
Files with missing lines Coverage Δ
daft/context.py 87.65% <ø> (ø)
src/common/daft-config/src/lib.rs 82.50% <100.00%> (+0.22%) ⬆️
src/daft-scan/src/scan_task_iters/mod.rs 90.98% <100.00%> (-0.31%) ⬇️
src/common/daft-config/src/python.rs 65.93% <57.14%> (-0.28%) ⬇️

... and 145 files with indirect coverage changes