-
Notifications
You must be signed in to change notification settings - Fork 180
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
perf: simplify boolean expression rules (#3731)
This PR adds the following: 1. `simplify` now recursively simplifies the entire expression tree 2. Simplification rules `simplify_and` and `simplify_or` to simplify boolean expressions 3. A simplify expressions step to the logical optimizer before scan task materialization I also did some refactoring work that did not change behavior: 1. Converted various functions to take in `Arc<T>` instead of `T`, which is more ergonomic to use and avoids a potential clone when calling it with an Arc variable using `Arc::unwrap_or_clone` 2. Split up simplify code into multiple files Combined with #3728, this PR brings major performance improvements to TPCH Q19 by pushing down and simplifying filter predicates.
- Loading branch information
1 parent
4048816
commit 78beff4
Showing
11 changed files
with
806 additions
and
563 deletions.
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.