Add support for AsyncChatEvent in Paper server #5908
Conversation
|
I've found a little bug when receiving the AsyncChatEvent synchronously (I didn't know that was possible). I'm fixing it. |
|
Fixed, it should work now. |
.../PaperProvider/src/main/java/net/ess3/provider/providers/PaperAsyncChatListenerProvider.java
Outdated
Show resolved
Hide resolved
|
Is there anything else I should do for this to get approved? |
|
I will get to it I promise 😁 I'm waiting on #6033 before this one |
|
I'm sorry. I'm not used to the review system. After our last conversation, no one replied, and I noticed a check next to your name stating that I had something pending.
I thought I had to manually re-request a review after closing the conversation and so did I. Sorry if I caused any inconvenience, for the next time I'll know it is not needed.
…________________________________
De: Euphyllia ***@***.***>
Enviado: jueves, 13 de febrero de 2025 19:25
Para: EssentialsX/Essentials ***@***.***>
Cc: Hernán Indíbil de la Cruz Calvo ***@***.***>; Author ***@***.***>
Asunto: Re: [EssentialsX/Essentials] Add support for AsyncChatEvent in Paper server (PR #5908)
[Euphillya]Euphillya left a comment (EssentialsX/Essentials#5908)<#5908 (comment)>
why ask me to do a review?
—
Reply to this email directly, view it on GitHub<#5908 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ABGHXRJNHXSTYJUS4UNYYMT2PTPTLAVCNFSM6AAAAABMUOGMTKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMNJXGQYTAMJTGI>.
You are receiving this because you authored the thread.
|
|
I don't know what you did there, but after the update I have an error in the chat after the Chat Game. Could not pass event AsyncChatEvent to EssentialsChat v2.21.0-dev+169-69ed07a What should I do now? Delete the game from the server? Server Paper 1.21.4-152 |
|
Are you saying you are having an incompatibility problem between Chat Game and the code from this fork? Or with the latest EssentialsDiscord version? If it's with this fork, could you provide the logs? |
|
EssentialsX@196a2a1 Fix startup issue with potion providers (EssentialsX#6055) EssentialsX@8313d52 Add config for use of Paper chat events (EssentialsX#6050) EssentialsX@3025ba5 Fix NPE when chat messages are canceled EssentialsX@5a839c4 Fix modifying messages with Paper chat events EssentialsX@e3e247d Add discord module support for Paper's chat events (EssentialsX#5908) EssentialsX@263dab5 Fix spawn command sending message before teleportation (EssentialsX#6025) EssentialsX@f5efa26 Fix per-world flight permissions EssentialsX@1ff24cb Use an identity map for Paper chat listener (EssentialsX#6067) EssentialsX@bad79b7 Fix /book command on 1.20+ (EssentialsX#6064) EssentialsX@5458241 Fix expired mails showing as unread on join (EssentialsX#6063) EssentialsX@fe27182 New Crowdin updates (EssentialsX#6037) EssentialsX@ba5257c Fix translation error in EssentialsSign#getItemStack EssentialsX@e49021f Fix item overflow issue with kits & trade signs EssentialsX@b5748eb Update various dependencies (EssentialsX#6078)
Information
This PR fixes #5243.
Details
Proposed fix:
Since the EssentialsDiscord plugin only listens to AsyncPlayerChatEvent, which
is called before calling AsyncChatEvent, any changes made to the message in the
latter event will be ignored by the plugin.
In order to fix it, I've added some classes to the PaperProvider and a new async
event which will be called each time an AsyncChatEvent is received.
The plugin checks if the AsyncChatEvent exists and registers the two listeners
needed instead of the bukkit one.
Environments tested:
OS: Ubuntu 24.04 LTS
Java version: Oracle GraalVM 21.0.3+7.1
Demonstration: