Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

l9 update #318

Merged
merged 32 commits into from
Feb 28, 2024
Merged

l9 update #318

merged 32 commits into from
Feb 28, 2024

Conversation

qunabu
Copy link
Contributor

@qunabu qunabu commented Feb 28, 2024

No description provided.

@qunabu qunabu self-assigned this Feb 28, 2024
Copy link

gitguardian bot commented Feb 28, 2024

⚠️ GitGuardian has uncovered 10 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
9573413 Triggered Generic High Entropy Secret 062c681 .env.example View secret
9573413 Triggered Generic High Entropy Secret 89279f7 .env.example View secret
9573413 Triggered Generic High Entropy Secret 278a779 .env.example View secret
9556638 Triggered Redis Server Password f722492 docker-compose.yml View secret
9556638 Triggered Redis Server Password 23270a8 docker-compose.yml View secret
9556638 Triggered Redis Server Password a6a4291 docker-compose.yml View secret
9556638 Triggered Redis Server Password 4dcde9b docker-compose.yml View secret
9556662 Triggered Generic Password a6a4291 .github/workflows/phpunit-tests.yml View secret
9556662 Triggered Generic Password a069c1a .github/workflows/phpunit-tests.yml View secret
9556662 Triggered Generic Password 4dcde9b .github/workflows/phpunit-tests.yml View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

Copy link

@codeclimate codeclimate bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR diff size of 21850 lines exceeds the maximum allowed for the inline comments feature.

Copy link

codeclimate bot commented Feb 28, 2024

Code Climate has analyzed commit 176ffa6 and detected 0 issues on this pull request.

View more on Code Climate.

@qunabu qunabu merged commit a3f74bd into main Feb 28, 2024
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants