add limit order pool integration #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…riceChange property and improving code formatting. Update tests to validate new property behavior.
0xKermo
commented
Jan 21, 2025
| @@ -114,3 +114,41 @@ export function approximateNumberOfTickSpacingsCrossed( | |||
|
|
|||
| return Math.floor(Math.abs(logPriceDiff / (tickSpacing * 251))); | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
I implemented this function from rust sdk. Limit order tests succes with this func
maybe i did something wrong here
| @@ -173,7 +177,56 @@ export class BasePool implements QuoteNode { | |||
| const nextInitializedTickSqrtRatio = nextInitializedTick | |||
| ? toSqrtRatio(nextInitializedTick.tick) | |||
| : null; | |||
|
|
|||
| */ | |||
There was a problem hiding this comment.
i changed here with my implementation but It works in limit order pool tests but other test scenarios are failed (base pool, twamm...)
maybe I did smth wrong here
| @@ -198,25 +251,33 @@ export class BasePool implements QuoteNode { | |||
| // cross the tick if the price moved all the way to the next initialized tick price | |||
| if (nextInitializedTick && sqrtRatio === nextInitializedTickSqrtRatio) { | |||
| activeTickIndex = isIncreasing | |||
| ? activeTickIndex + 1 | |||
| : activeTickIndex - 1; | |||
| ? nextInitializedTick.index | |||
There was a problem hiding this comment.
change here due to the above changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added limit order pool integration and tests according to rust sdk test cases.
I left comments about other changes