-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new methods for getting text grades #90
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work, LGTM! :)
I can't test in on live data since I don't have any text grades :(
edupage_api/__init__.py
Outdated
list[EduGrade]: List of `EduTextGrade`s | ||
""" | ||
|
||
return Grades(self).get_grades(year=None, term=None) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe return Grades(self).get_text_grades(year=None, term=None)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice catch!
Fixes #71
I've added a new class:
And 2 new methods:
@mgrfilipmarek Can you please test? Feel free to suggest any more fields that should be added.
You can install the test version with this command:
And to revert back: