Skip to content
This repository has been archived by the owner on Aug 7, 2024. It is now read-only.

data: shaileshthakur1 #9832

Merged
merged 2 commits into from
Nov 26, 2023
Merged

data: shaileshthakur1 #9832

merged 2 commits into from
Nov 26, 2023

Conversation

shaileshthakur1
Copy link
Member

Fixes Issue

Changes proposed

Check List (Check all the applicable boxes)

  • My code follows the code style of this project.
  • My change requires changes to the documentation.
  • I have updated the documentation accordingly.
  • All new and existing tests passed.
  • This PR does not contain plagiarized content.
  • The title of my pull request is a short description of the requested changes.

Screenshots

Note to reviewers

@github-actions github-actions bot added invalid Inappropriate or invalid for Hacktoberfest contributions ✍ chore: profile This label will be added on PR with request of Data json addition labels Nov 25, 2023
sital002
sital002 reviewed Nov 25, 2023
View reviewed changes
data/shaileshthakur1.json Outdated Show resolved Hide resolved
sital002
sital002 reviewed Nov 25, 2023
View reviewed changes
data/shaileshthakur1.json Outdated Show resolved Hide resolved
sital002
sital002 reviewed Nov 25, 2023
View reviewed changes
data/shaileshthakur1.json Outdated Show resolved Hide resolved
sital002
sital002 suggested changes Nov 25, 2023
View reviewed changes
Copy link
Member

@sital002 sital002 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make the necessary changes to get your profile merged.

@shaileshthakur1
Copy link
Member Author

hey @sital002 , I've updated it all. Please review now.

sital002
sital002 approved these changes Nov 26, 2023
View reviewed changes
Copy link
Member

@sital002 sital002 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@sital002 sital002 merged commit f85ead6 into EddieHubCommunity:main Nov 26, 2023
5 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sital002 sital002 sital002 approved these changes

Assignees
No one assigned
Labels
✍ chore: profile This label will be added on PR with request of Data json addition invalid Inappropriate or invalid for Hacktoberfest contributions
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shaileshthakur1 @sital002