Skip to content
This repository has been archived by the owner on Aug 7, 2024. It is now read-only.

Create Haruhue.json #10170

Closed
wants to merge 6 commits into from
Closed

Create Haruhue.json #10170

wants to merge 6 commits into from

Conversation

Haru-hue
Copy link
Contributor

@Haru-hue Haru-hue commented Jan 23, 2024

Check List (Check all the applicable boxes)

  • My code follows the code style of this project.
  • My change requires changes to the documentation.
  • I have updated the documentation accordingly.
  • All new and existing tests passed.
  • This PR does not contain plagiarized content.
  • The title of my pull request is a short description of the requested changes.

@github-actions github-actions bot added invalid Inappropriate or invalid for Hacktoberfest contributions ✍ chore: profile This label will be added on PR with request of Data json addition labels Jan 23, 2024
@Haru-hue
Copy link
Contributor Author

@eddiejaoude
Copy link
Member

Please do not tag maintainers like that, we already get the notification, adding more notifications does not help. It was only a few minutes since you raised the PR, we all live in different timezones, please be patient, we will get to your PR soon.

Please read the contributing guide https://github.com/EddieHubCommunity/BioDrop/blob/main/CONTRIBUTING.md

@Haru-hue
Copy link
Contributor Author

Please do not tag maintainers like that, we already get the notification, adding more notifications does not help. It was only a few minutes since you raised the PR, we all live in different timezones, please be patient, we will get to your PR soon.

Please read the contributing guide https://github.com/EddieHubCommunity/BioDrop/blob/main/CONTRIBUTING.md

Sorry about that

Copy link
Member

@SaraJaoude SaraJaoude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove the changes to the file TobySolutions/testimonials - this does not relate to your Profile or a testimonial given by you or to you.

@Haru-hue
Copy link
Contributor Author

Please remove the changes to the file TobySolutions/testimonials - this does not relate to your Profile or a testimonial given by you or to you.

I already did that

@eddiejaoude
Copy link
Member

I already did that

You deleted the file from someone else's profile, for your PR to be accepted please remove your changes to the file (not delete the file) from your Pull Request, there should be no changes over than your json file in the "files changed" tab, please check again

Here is a screenshot to help

Screenshot 2024-01-23 at 09 59 28

@Haru-hue Haru-hue closed this Jan 23, 2024
@Haru-hue Haru-hue reopened this Jan 23, 2024
@Haru-hue Haru-hue closed this Jan 23, 2024
@eddiejaoude
Copy link
Member

You don't need to close your Pull Request, you can undo your changes to that file, I made a video on it
https://www.youtube.com/watch?v=YUHS5Ana7Jw

But if easier, you can create a new pull request. Any questions come and chat to us in the EddieHub Discord https://discord.com/invite/jZQs6Wu

@Haru-hue
Copy link
Contributor Author

Tried undoing it but it was not working and frustrating, I made a new one:
#10171

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
✍ chore: profile This label will be added on PR with request of Data json addition invalid Inappropriate or invalid for Hacktoberfest contributions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants