Skip to content
This repository has been archived by the owner on Aug 7, 2024. It is now read-only.

data: Prashanth-bokkala #10030

Merged
merged 1 commit into from
Dec 26, 2023
Merged

data: Prashanth-bokkala #10030

merged 1 commit into from
Dec 26, 2023

Conversation

Prashanth-bokkala
Copy link
Contributor

@Prashanth-bokkala Prashanth-bokkala commented Dec 26, 2023

Fixes Issue

Changes proposed

Check List (Check all the applicable boxes)

  • My code follows the code style of this project.
  • My change requires changes to the documentation.
  • I have updated the documentation accordingly.
  • All new and existing tests passed.
  • This PR does not contain plagiarized content.
  • The title of my pull request is a short description of the requested changes.

Screenshots

Note to reviewers

@github-actions github-actions bot added invalid Inappropriate or invalid for Hacktoberfest contributions ✍ chore: profile This label will be added on PR with request of Data json addition labels Dec 26, 2023
Copy link
Member

@sital002 sital002 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make the necessary changes to get your profile merged.

@Prashanth-bokkala
Copy link
Contributor Author

Please make the necessary changes to get your profile merged.

yes , but they shown in the tutorial about this so i included that , and mainly i checked the code with Playground in that , its shown that its a valid code , i checked twice before made pull request , if you still need changes please let me know

@Prashanth-bokkala Prashanth-bokkala marked this pull request as draft December 26, 2023 15:18
@Prashanth-bokkala Prashanth-bokkala marked this pull request as ready for review December 26, 2023 15:23
@sital002
Copy link
Member

sital002 commented Dec 26, 2023

Please make the necessary changes to get your profile merged.

yes , but they shown in the tutorial about this so i included that , and mainly i checked the code with Playground in that , its shown that its a valid code , i checked twice before made pull request , if you still need changes please let me know

Yes those fields were required but now they are not required anymore so there is no need to add it. The JSON playground only checks for whether the json is valid or not.
image
I will attach the link for json quick guide.
https://www.biodrop.io/docs/quickstart-json

Copy link
Member

@sital002 sital002 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍
Welcome to Eddiehub community ✨✨

@sital002 sital002 merged commit 0a5a407 into EddieHubCommunity:main Dec 26, 2023
5 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
✍ chore: profile This label will be added on PR with request of Data json addition invalid Inappropriate or invalid for Hacktoberfest contributions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants