Image import from tar archives #75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…), Services and Jobs frontend componenets can handle empty lists correctly
emanueldima
requested changes
Apr 4, 2017
Makefile
Outdated
| @@ -10,14 +10,14 @@ webui: | |||
|
|
|||
| containers: | |||
| (cd $(INTERNALSERVICES)/volume-stage-in && docker build -t volume-stage-in .) | |||
| (cd $(INTERNALSERVICES)/volume-filelist && GOOS=linux GOARCH=amd64 go build && docker build -t volume-filelist .) | |||
| (cd $(INTERNALSERVICES)/volume-filelist && GOOS=linux GOARCH=amd64 go build -ldflags -s && docker build -t volume-filelist .) | |||
There was a problem hiding this comment.
Please define GOFLAGS=-ldflags -s at the top of the makefile and use go build $(GOFLAGS) where needed, this way we can change the flags once.
| if _, err := os.Stat(filepath.Join(buildDir, "Dockerfile")); os.IsNotExist(err) { | ||
| Response{w}.ServerError("no Dockerfile to build new image ", err) | ||
| return | ||
| if strings.HasSuffix(strings.ToLower(part.FileName()), ".tar") || strings.HasSuffix(strings.ToLower(part.FileName()), ".tar.gz") { |
There was a problem hiding this comment.
I think the logic is not perfect here. I would first save all the files on the file system, and then 1. if there exists a Dockerfile, assume build image is expected, or 2. if there is a single tar file, assume an image.
Right now the user may send a Dockerfile together with a .tar file that is used in the Dockerfile, and the assumption that the .tar file is an image would be incorrect.
emanueldima
approved these changes
Apr 4, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Image import from tar archives has been implemented. Metadata is extracted from Manifest.json, since there is a problem with the Docker remote API (fsouza/go-dockerclient#645 (comment)). Makefile has been modified to work on Mac (the last update made go partly incompatible with the latest XCode). Services.jsx and Jobs.jsx do not throw exceptions when an empty list is found, instead we show a simple message. Updated React-Dropzone component, but it still cannot handle correctly multiple file upload: uploading is done in chunks of two files (by default), ImageBuild fails, if a Dockerfile is not in the first chunk (has to be investigated #74).