Added support to use adios2's flatten_step #5634
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To enable it, put it in the openPMD option through input file.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
ax3l
added
component: openPMD
lucafedeli88
reviewed
Feb 4, 2025
There was a problem hiding this comment.
Thanks for this PR, @guj !
I've left few comments, mainly to make clang-tidy and CodeQL happy.
Added braces for the if/else loop via Luca Fedeli Co-authored-by: Luca Fedeli <[email protected]>
added const to bool variable via Luca Fedeli Co-authored-by: Luca Fedeli <[email protected]>
eliminate extra space Co-authored-by: Luca Fedeli <[email protected]>
remove commented line via Luca Fedeli Co-authored-by: Luca Fedeli <[email protected]>
Remove commented line via Luca Fedeli Co-authored-by: Luca Fedeli <[email protected]>
lucafedeli88
reviewed
Feb 6, 2025
| @@ -176,6 +176,7 @@ private: | |||
| } | |||
| } | |||
|
|
|||
| void flushCurrent(bool isBTD) const; | |||
There was a problem hiding this comment.
Would it be possible to add a doc-string to document this function?
There was a problem hiding this comment.
I added doc for this function
Source/Diagnostics/WarpXOpenPMD.cpp
Outdated
| void WarpXOpenPMDPlot::flushCurrent(bool isBTD) const | ||
| { | ||
| WARPX_PROFILE("WarpXOpenPMDPlot::flushCurrent"); | ||
| // open files from all processors, in case some will not contribute below |
There was a problem hiding this comment.
These comments can be adapted to write a doc-string for the function declaration
There was a problem hiding this comment.
Added documentation for this function.
typo spotted by Luca Fedeli Co-authored-by: Luca Fedeli <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To enable it, put it in the openPMD option through input file:
e.g.
This feature is useful for BTD use case. Data can be flushed after each buffered writes of a snapshot
To check weather this feature is in use, try "bpls -V your_bp_file_name"