Add MCC forward scattering #5621
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roelof-groenewald
requested changes
Feb 4, 2025
There was a problem hiding this comment.
Thank you very much for the contribution!
The PR looks good. I just have two requests for small changes.
Btw, we do have tests for MCC (https://github.com/ECP-WarpX/WarpX/tree/development/Examples/Physics_applications/capacitive_discharge). The cross-sections for such tests are kept in a separate repo: https://github.com/ECP-WarpX/warpx-data.
* Added a reference for the forward scattering theory section * Included excitation and forward scattering as possible scattering processes for ions in the usage section
roelof-groenewald
approved these changes
Feb 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a version of forward scattering suggested in J F J Janssen et al (2016). This process decreases total particle energy by the process' energy threshold. If no energy threshold is given in the input file, this process is equivalent to no collision being carried out (no scattering and no energy change).
Adjusted documentation appropriately and fixed a pre-existing typo.
Feature was tested on my own machine by confirming with python callbacks that the pre-collision and post-collision velocities were equal in the case of no energy cost threshold being supplied, and that the velocities were scaled down by the appropriate amount when a threshold was supplied (it was also checked that particle direction was the same before and after collision). No formal test was added since no current MCC tests exist and adding a framework to access cross sections while executing tests was prohibitive.