Move Fornberg coefficients calculations from WarpX to ablastr #5619
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The calculation of Fornberg stencil coefficients is rather general, and it can be shared with other projects of the BLAST family. Therefore, this PR moves the responsible functions into
ablastr
.Specifically, the PR does the following:
FiniteDifference.H
andFiniteDifference.cpp
) are created underablastr/math
(CMakeLists.txt
andMake.package
accordingly)getFornbergStencilCoefficients
and theReorderFornbergCoefficients
function (originally defined in an anonymous namespace inWarpX.cpp
) are moved to these new files, inside the namespaceablastr::math
AMREX_ALWAYS_ASSERT_WITH_MESSAGE
becomesABLASTR_ALWAYS_ASSERT_WITH_MESSAGE
)WarpX.cpp
andSpectralKSpace.cpp
(where the aforementioned functions were called) are updatedNote that with this PR
SpectralKSpace.cpp
does not need anymore to include the heavyWarpX.H
header.