WarpX class: move shiftMF to anonymous namespace in WarpXMovingWindow.cpp #5609
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…_to_anonymous_namespace
lucafedeli88
changed the title
ax3l
reviewed
Jan 29, 2025
| const bool PMLRZ_flag = false) | ||
| { | ||
| using namespace amrex::literals; | ||
| WARPX_PROFILE("::shiftMF()"); |
There was a problem hiding this comment.
Does this still have a sensible prefix in the BL Profiler?
There was a problem hiding this comment.
It depends on what you mean for sensible ;-) ! It appears like that at the moment:
---------------------------------------------------------------------------------------------------
Name NCalls Excl. Min Excl. Avg Excl. Max Max %
---------------------------------------------------------------------------------------------------
::shiftMF() 591 0.8066 0.8066 0.8066 18.74%
WarpX::OneStep_nosub() 100 0.6293 0.6293 0.6293 14.62%
PhysicalParticleContainer::Evolve() 100 0.4915 0.4915 0.4915 11.42%
ParticleContainer::RedistributeCPU() 304 0.4015 0.4015 0.4015 9.33%
FillBoundary_nowait() 1819 0.2607 0.2607 0.2607 6.06%
Filter::ApplyStencil(MultiFab) 303 0.2414 0.2414 0.2414 5.61%
FlushFormatOpenPMD::WriteToFile() 2 0.2344 0.2344 0.2344 5.45%
Do you have an alternative in mind? Just shiftMF maybe ?
| @@ -57,6 +57,184 @@ | |||
|
|
|||
| using namespace amrex; | |||
|
|
|||
| namespace | |||
| { | |||
| void shiftMF ( | |||
There was a problem hiding this comment.
Adding a Doxygen string on the way would be really nice :)
lucafedeli88
commented
Jan 30, 2025
| const int nc = mf.nComp(); | ||
| const amrex::IntVect& ng = mf.nGrowVect(); | ||
|
|
||
| AMREX_ALWAYS_ASSERT(ng[dir] >= std::abs(num_shift)); |
There was a problem hiding this comment.
Previously, this was AMREX_ALWAYS_ASSERT(ng[dir] >= num_shift);
however, it seems to me that, since num_shift can be negative, we need an absolute value here. What do you think @ax3l ?
lucafedeli88
commented
Jan 30, 2025
| } else { | ||
| amrex::IntVect ng_mw = amrex::IntVect::TheUnitVector(); | ||
| // Enough guard cells in the MW direction | ||
| ng_mw[dir] = std::abs(num_shift); |
There was a problem hiding this comment.
Same as above. This was ng_mw[dir] = num_shift;, but I think that the absolute value is necessary here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves the static function
shiftMFfrom the WarpX class to an anonymous namespace inWarpXMovingWindow.cpp, where it is actually used.This is done to simplify the Warpx class.