Merge ECP-WarpX:development into EZoni:remove_tmp_particle_data

.azure-pipelines.yml

@@ -141,7 +141,7 @@ jobs:
       df -h
       # configure
       export AMReX_CMAKE_FLAGS="-DAMReX_ASSERTIONS=ON -DAMReX_TESTING=ON"
-      export WARPX_TEST_FLAGS="-DWarpX_TEST_CLEANUP=ON -DWarpX_TEST_FPETRAP=ON -DWarpX_TEST_DEBUG=ON"
+      export WARPX_TEST_FLAGS="-DWarpX_TEST_CLEANUP=ON -DWarpX_TEST_FPETRAP=ON -DWarpX_BACKTRACE_INFO=ON"
       cmake -S . -B build    \
         ${AMReX_CMAKE_FLAGS} \
         ${WARPX_CMAKE_FLAGS} \
@@ -155,8 +155,16 @@ jobs:
   - bash: |
       # set options
       set -o nounset errexit pipefail
-      # run tests (exclude pytest.AMReX when running Python tests)
-      ctest --test-dir build --output-on-failure -E AMReX
+      # determine if the build was triggered by a push to the development branch
+      if [[ "$(Build.SourceBranch)" == "refs/heads/development" ]]; then
+        # run tests (exclude pytest.AMReX when running Python tests)
+        # and submit results to CDash as Experimental
+        ctest --test-dir build --output-on-failure -E AMReX \
+          -D ExperimentalTest -D ExperimentalSubmit
+      else
+        # run tests (exclude pytest.AMReX when running Python tests)
+        ctest --test-dir build --output-on-failure -E AMReX
+      fi
     displayName: 'Test'
 
   - bash: |

.clang-tidy

@@ -44,6 +44,7 @@ Checks: '
         -readability-implicit-bool-conversion,
         -readability-isolate-declaration,
         -readability-magic-numbers,
+        -readability-misleading-indentation,
         -readability-named-parameter,
         -readability-uppercase-literal-suffix
     '
@@ -55,6 +56,8 @@ CheckOptions:
   value:        "H,"
 - key:          modernize-pass-by-value.ValuesOnly
   value:        "true"
+- key:          misc-use-anonymous-namespace.HeaderFileExtensions
+  value:        "H,"
 
 
 HeaderFilterRegex: 'Source[a-z_A-Z0-9\/]+\.H$'

.github/ISSUE_TEMPLATE/blank_issue.md

@@ -0,0 +1,14 @@
+---
+name: Blank issue
+about: Ask us a question
+labels: [question]
+---
+
+Are you here because you have something to report that is neither a bug, a new feature, nor an installation problem?
+
+Before opening this issue, consider opening a [discussion](https://github.com/ECP-WarpX/WarpX/discussions) instead!
+
+Issues are used to report bugs, installation problems or to request new features.
+Discussions are used to ask more open-ended questions, brainstorm, ask our feedback, etc.
+
+You can find more details on how to use issues and discussions [here](https://github.com/ECP-WarpX/WarpX/blob/development/CONTRIBUTING.rst).

.github/ISSUE_TEMPLATE/config.yml

@@ -1 +1 @@
-blank_issues_enabled: true
+blank_issues_enabled: false

.github/workflows/clang_sanitizers.yml

@@ -27,7 +27,7 @@ jobs:
     - uses: actions/checkout@v4
     - name: install dependencies
       run: |
-        .github/workflows/dependencies/clang17.sh
+        .github/workflows/dependencies/clang.sh 17
     - name: CCache Cache
       uses: actions/cache@v4
       with:
@@ -89,7 +89,7 @@ jobs:
     - uses: actions/checkout@v4
     - name: install dependencies
       run: |
-        .github/workflows/dependencies/clang17.sh
+        .github/workflows/dependencies/clang.sh 17
     - name: CCache Cache
       uses: actions/cache@v4
       with:

.github/workflows/clang_tidy.yml

@@ -20,13 +20,13 @@ jobs:
         dim: [1, 2, RZ, 3]
     name: clang-tidy-${{ matrix.dim }}D
     runs-on: ubuntu-22.04
-    timeout-minutes: 180
+    timeout-minutes: 250
     if: github.event.pull_request.draft == false
     steps:
     - uses: actions/checkout@v4
     - name: install dependencies
       run: |
-        .github/workflows/dependencies/clang15.sh
+        .github/workflows/dependencies/clang.sh 16
     - name: set up cache
       uses: actions/cache@v4
       with:
@@ -43,8 +43,8 @@ jobs:
         export CCACHE_LOGFILE=${{ github.workspace }}/ccache.log.txt
         ccache -z
 
-        export CXX=$(which clang++-15)
-        export CC=$(which clang-15)
+        export CXX=$(which clang++-16)
+        export CC=$(which clang-16)
 
         cmake -S . -B build_clang_tidy      \
           -DCMAKE_VERBOSE_MAKEFILE=ON       \
@@ -62,7 +62,7 @@ jobs:
 
         ${{github.workspace}}/.github/workflows/source/makeMakefileForClangTidy.py --input ${{github.workspace}}/ccache.log.txt
         make -j4 --keep-going -f clang-tidy-ccache-misses.mak \
-            CLANG_TIDY=clang-tidy-15 \
+            CLANG_TIDY=clang-tidy-16 \
             CLANG_TIDY_ARGS="--config-file=${{github.workspace}}/.clang-tidy --warnings-as-errors=*"
 
         ccache -s

.github/workflows/cuda.yml

@@ -56,7 +56,7 @@ jobs:
         which nvcc || echo "nvcc not in PATH!"
 
         cmake-easyinstall --prefix=/usr/local \
-          git+https://github.com/openPMD/openPMD-api.git@0.15.1 \
+          git+https://github.com/openPMD/openPMD-api.git@0.16.1 \
           -DopenPMD_USE_PYTHON=OFF    \
           -DBUILD_TESTING=OFF         \
           -DBUILD_EXAMPLES=OFF        \
@@ -127,7 +127,7 @@ jobs:
         which nvcc || echo "nvcc not in PATH!"
 
         git clone https://github.com/AMReX-Codes/amrex.git ../amrex
-        cd ../amrex && git checkout --detach e761abff95afbfa442cbe108027094bbddef5b11 && cd -
+        cd ../amrex && git checkout --detach 69f1ac884c6aba4d9881260819ade3bb25ed8aad && cd -
         make COMP=gcc QED=FALSE USE_MPI=TRUE USE_GPU=TRUE USE_OMP=FALSE USE_FFT=TRUE USE_CCACHE=TRUE -j 4
 
         ccache -s

.github/workflows/dependencies/clang17.sh → .github/workflows/dependencies/clang.sh

@@ -1,45 +1,50 @@
 #!/usr/bin/env bash
 #
-# Copyright 2024 The WarpX Community
+# Copyright 2025 The WarpX Community
 #
 # License: BSD-3-Clause-LBNL
-# Authors: Luca Fedeli
 
 set -eu -o pipefail
 
-# `man apt.conf`:
-#   Number of retries to perform. If this is non-zero APT will retry
-#   failed files the given number of times.
+# `man apt.conf`: number of retries to perform (if non-zero,
+# APT will retry failed files the given number of times).
 echo 'Acquire::Retries "3";' | sudo tee /etc/apt/apt.conf.d/80-retries
 
-# This dependency file is currently used within a docker container,
-# which does not come (among others) with wget, xz-utils, curl, git,
-# ccache, and pkg-config pre-installed.
-sudo apt-get -qqq update
+sudo apt-get update
 sudo apt-get install -y \
     cmake               \
-    clang-17            \
-    clang-tidy-17       \
     libblas-dev         \
-    libc++-17-dev       \
     libboost-math-dev   \
     libfftw3-dev        \
     libfftw3-mpi-dev    \
     libhdf5-openmpi-dev \
     liblapack-dev       \
     libopenmpi-dev      \
-    libomp-17-dev       \
-    ninja-build         \
-    wget                \
-    xz-utils            \
-    curl                \
-    git                 \
-    ccache              \
-    pkg-config
+    ninja-build
 
-# Use clang 17
-export CXX=$(which clang++-17)
-export CC=$(which clang-17)
+# parse clang version number from command line
+version_number=${1}
+
+# add LLVM repository and install clang tools
+wget https://apt.llvm.org/llvm.sh
+chmod +x llvm.sh
+sudo ./llvm.sh ${version_number}
+
+# install clang, clang-tidy, and
+# LLVM implementations of C++ standard library and OpenMP
+sudo apt-get update
+sudo apt-get install -y          \
+    clang-${version_number}      \
+    clang-tidy-${version_number} \
+    libc++-${version_number}-dev \
+    libomp-${version_number}-dev
+
+# export compiler flags
+export CXX=$(which clang++-${version_number})
+export CC=$(which clang-${version_number})
+
+# ccache
+$(dirname "$0")/ccache.sh
 
 # cmake-easyinstall
 #

.github/workflows/dependencies/icc.sh

@@ -58,7 +58,7 @@ export CEI_TMP="/tmp/cei"
 CXX=$(which icpc) CC=$(which icc) \
   cmake-easyinstall               \
   --prefix=/usr/local             \
-  git+https://github.com/openPMD/openPMD-api.git@0.15.2 \
+  git+https://github.com/openPMD/openPMD-api.git@0.16.1 \
   -DopenPMD_USE_PYTHON=OFF \
   -DBUILD_TESTING=OFF      \
   -DBUILD_EXAMPLES=OFF     \

.pre-commit-config.yaml

@@ -69,7 +69,7 @@ repos:
 # Python: Ruff linter & formatter
 #   https://docs.astral.sh/ruff/
 - repo: https://github.com/astral-sh/ruff-pre-commit
-  rev: v0.9.1
+  rev: v0.9.3
   hooks:
     # Run the linter
     - id: ruff

CMakeLists.txt

@@ -81,18 +81,19 @@ option(WarpX_QED_TABLE_GEN "QED table generation (requires PICSAR and Boost)"
 option(WarpX_QED_TOOLS     "Build external tool to generate QED lookup tables (requires PICSAR and Boost)"
                                                                         OFF)
 
-# Advanced option to automatically clean up CI test directories
-option(WarpX_TEST_CLEANUP "Clean up CI test directories" OFF)
+# Advanced option to run tests
+option(WarpX_TEST_CLEANUP "Clean up automated test directories" OFF)
+option(WarpX_TEST_DEBUGGER "Run automated tests without AMReX signal handling (to attach debuggers)" OFF)
+option(WarpX_TEST_FPETRAP "Run automated tests with FPE-trapping runtime parameters" OFF)
 mark_as_advanced(WarpX_TEST_CLEANUP)
-
-# Advanced option to run CI tests with FPE-trapping runtime parameters
-option(WarpX_TEST_FPETRAP "Run CI tests with FPE-trapping runtime parameters" OFF)
+mark_as_advanced(WarpX_TEST_DEBUGGER)
 mark_as_advanced(WarpX_TEST_FPETRAP)
 
-# Advanced option to run CI tests with the -g compile option
-option(WarpX_TEST_DEBUG "Run CI tests with the -g compile option" OFF)
-mark_as_advanced(WarpX_TEST_DEBUG)
-if(WarpX_TEST_DEBUG)
+# Advanced option to compile with the -g1 option for minimal debug symbols
+# (useful to see, e.g., line numbers in backtraces)
+option(WarpX_BACKTRACE_INFO "Compile with -g1 for minimal debug symbols (currently used in CI tests)" OFF)
+mark_as_advanced(WarpX_BACKTRACE_INFO)
+if(WarpX_BACKTRACE_INFO)
     set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -g1")
 endif()
 
@@ -193,7 +194,8 @@ if(WarpX_FFT)
     set(ABLASTR_FFT ON CACHE STRING "FFT-based solvers" FORCE)
 endif()
 
-# this defined the variable BUILD_TESTING which is ON by default
+# Define the variable BUILD_TESTING (ON by default),
+# include CDash dashboard testing module
 include(CTest)
 
 

CONTRIBUTING.rst

@@ -12,6 +12,36 @@ Git workflow
 The WarpX project uses `git <https://git-scm.com>`_ for version control.
 If you are new to git, you can follow `this tutorial <https://swcarpentry.github.io/git-novice/>`__.
 
+
+What to do when
+^^^^^^^^^^^^^^^
+
+Issues
+""""""
+
+`Issues <https://github.com/ECP-WarpX/WarpX/issues>`__ are used to track tasks that the contributors and/or maintainers can work on.
+Use issues for reporting bugs or installation problems and for requesting new features.
+
+If you've found a bug and wish to report it, first search the open issues and `pull requests <https://github.com/ECP-WarpX/WarpX/pulls>`__ to see if someone else has already reported the same thing.
+If it's something new, open an issue using a template.
+We'll use the issue to address the problem you've encountered.
+
+Discussions
+"""""""""""
+
+`Discussions <https://github.com/ECP-WarpX/WarpX/discussions>`__ are for open-ended conversations, general questions, brainstorming ideas.
+Please, use discussions if you want to ask us something that is not technically a bug or a feature.
+Feel free to ping us there!
+
+Pull Requests (PRs)
+"""""""""""""""""""
+
+Open a `pull request <https://github.com/ECP-WarpX/WarpX/pulls>`__ if you want to add a new feature yourself.
+Follow the guide below for more details.
+
+
+Thank you for contributing! 🥰
+
 Configure your GitHub Account & Development Machine
 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
 

CTestConfig.cmake

@@ -0,0 +1,20 @@
+## This file should be placed in the root directory of your project.
+## Then modify the CMakeLists.txt file in the root directory of your
+## project to incorporate the testing dashboard.
+##
+## # The following are required to submit to the CDash dashboard:
+##   ENABLE_TESTING()
+##   INCLUDE(CTest)
+
+set(CTEST_PROJECT_NAME WarpX)
+set(CTEST_NIGHTLY_START_TIME 08:00:00 UTC)
+
+set(CTEST_SUBMIT_URL https://my.cdash.org/submit.php?project=WarpX)
+
+set(CTEST_DROP_SITE_CDASH TRUE)
+
+# Set site and build names
+# - CTest script variables: CTEST_SITE, CTEST_BUILD_NAME
+# - CTest module variables: SITE, BUILDNAME
+set(SITE "Azure-Pipelines")
+set(BUILDNAME "CI-Development")

Docs/source/dataanalysis/workflows.rst

@@ -1,7 +1,8 @@
+.. _dataanalysis-how-to:
 .. _dataanalysis-workflows:
 
-Workflows
-=========
+How-To Guides
+=============
 
 This section collects typical user workflows and best practices for data analysis with WarpX.