-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Switch to a different completed tasks endpoint #200
base: main
Are you sure you want to change the base?
Conversation
ae98783
to
9edf899
Compare
9edf899
to
8ea8203
Compare
The order in which PRs should be merged are as follows:
@nats12 I've tagged you in this as the frontend's API update person. If you need assistance to test the PR when (1) has been merged, please speak to Pawel or Francesca, but it should be easy enough to get going. @PotHix for visibility. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
3 can be merged in any order. The deprecation of the endpoint will only affect new minor versions, and the actual deprecation of v9 will happen ~Q2 2025. @nats12 I will ping you as soon as the changes are in place. @scottlovegrove will be OOO for holidays soon. :) |
An update here, since it's been a month... The change was not that simple, and we couldn't finish it before vacations. I will give it a look in the next few days. |
cc'ing @pedroalves0 here too from the Transactions squad for visibility. We are switching to a different completed tasks endpoint in v9.205. |
Overview
The endpoint we were using for completed tasks is being deprecated and we need to move to a new one.
Initially this would have been to move to
archive/items
, but this is to be renamed shortly totasks/archived
. I've gone with the latter here, even though it's not live, so this PR can't be merged until this one on the backend has been.I've also increased the limit to 200, as per the docs of the endpoint to be used to decrease the number of times we may have to call it.
Reference
PR to deprecate the existing endpoint: https://github.com/Doist/Todoist/pull/19393
PR to rename endpoint: https://github.com/Doist/Todoist/pull/19394
Test Plan