Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Superpixel speed improvements #116

Merged
merged 8 commits into from
May 7, 2024
Merged

Conversation

bnmajor
Copy link
Collaborator

@bnmajor bnmajor commented Mar 12, 2024

Currently works when concurrency is 1. Needs support for queuing in the case of larger concurrency values.

@bnmajor bnmajor force-pushed the superpixel-speed-improvements branch 2 times, most recently from 825e883 to 1753995 Compare March 18, 2024 13:30
@bnmajor bnmajor force-pushed the superpixel-speed-improvements branch from 1753995 to 454c639 Compare March 25, 2024 14:49
@bnmajor bnmajor marked this pull request as ready for review March 25, 2024 14:50
@manthey
Copy link
Contributor

manthey commented Apr 23, 2024

@bnmajor Can you merge or rebase this on master? I filed an issue (#123) related to it, and I'm seeing something else odd, but maybe updating to master will help.

@bnmajor bnmajor force-pushed the superpixel-speed-improvements branch from 454c639 to a85ab32 Compare April 23, 2024 17:05
@bnmajor
Copy link
Collaborator Author

bnmajor commented Apr 23, 2024

@bnmajor Can you merge or rebase this on master? I filed an issue (#123) related to it, and I'm seeing something else odd, but maybe updating to master will help.

Rebased!

@manthey
Copy link
Contributor

manthey commented Apr 25, 2024

I have a case where I have two images and started finding superpixels. I created my label categories. When the first image finished, I labelled some pixels. I then clicked "Begin Training" while the second image's superpixels were still being calculated (and neither had their features extracted). I see a javascript error:

Internal Server Error {"message": "KeyError: KeyError('jobId')", "trace": ["<FrameSummary file /opt/girder/girder/api/rest.py, line 655 in endpointDecorator>", "<FrameSummary file /opt/girder/girder/api/rest.py, line 1247 in POST>", "<FrameSummary file /opt/girder/girder/api/rest.py, line 983 in handleRoute>", "<FrameSummary file /opt/girder/girder/api/rest.py, line 1302 in wrapped>", "<FrameSummary file /opt/girder/girder/api/access.py, line 56 in wrapped>", "<FrameSummary file /opt/slicer_cli_web/slicer_cli_web/rest_slicer_cli.py, line 545 in rerunHandler>"], "type": "internal", "uid": "d5b21caf-a6b2-495a-8ed5-883aa5bb8f9a"}

Reloading the page gets over this.

Also, if you reload the page before any superpixels are finished calculating, you see the initial options page for picking superpixel size, etc.

@bnmajor bnmajor force-pushed the superpixel-speed-improvements branch from 0418a17 to 21a88b7 Compare April 29, 2024 20:15
@bnmajor
Copy link
Collaborator Author

bnmajor commented Apr 29, 2024

I have a case where I have two images and started finding superpixels. I created my label categories. When the first image finished, I labelled some pixels. I then clicked "Begin Training" while the second image's superpixels were still being calculated (and neither had their features extracted). I see a javascript error [...] Reloading the page gets over this.

Also, if you reload the page before any superpixels are finished calculating, you see the initial options page for picking superpixel size, etc.

I believe that both of these issues should be corrected now.

@bnmajor bnmajor merged commit 5c10ed9 into master May 7, 2024
2 checks passed
@bnmajor bnmajor deleted the superpixel-speed-improvements branch May 7, 2024 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants