Do not always call filter/sort/group on comparison change

For the comparison filters make sure that we confirm that the first option and operator have been set before trying to update any filtering.
DigitalSlideArchive · Jan 29, 2025 · 570dbf8 · 570dbf8
1 parent 4a7badc
commit 570dbf8
Showing 1 changed file with 9 additions and 8 deletions.
diff --git a/...ng/web_client/views/vue/components/ActiveLearningReview/ActiveLearningReviewContainer.vue b/...ng/web_client/views/vue/components/ActiveLearningReview/ActiveLearningReviewContainer.vue
@@ -127,12 +127,12 @@ export default Vue.extend({
         userSelections() {
             return [
                 ...store.filterBy,
-                this.firstComparison,
-                this.secondComparison,
-                this.booleanOperator,
                 ...this.sortBy,
                 ...this.groupBy
             ];
+        },
+        comparisonSelections() {
+            return [this.firstComparison, this.booleanOperator, this.secondComparison];
         }
     },
     watch: {
@@ -155,11 +155,12 @@ export default Vue.extend({
             }
             this.$nextTick(() => this.updateObserved());
         },
-        firstComparison() {
-            this.showFlags = !!this.firstComparison && !!this.booleanOperator;
-        },
-        booleanOperator() {
+        comparisonSelections(_newComps, oldComps) {
+            const [oldFirst, oldBoolean] = oldComps;
             this.showFlags = !!this.firstComparison && !!this.booleanOperator;
+            if (this.showFlags || (oldFirst && oldBoolean)) {
+                this.updateFilteredSortedGroupedSuperpixels();
+            }
         },
         userSelections() {
             this.updateFilteredSortedGroupedSuperpixels();
@@ -473,7 +474,7 @@ export default Vue.extend({
                 results = this.filterBySlideName(results, filterBy);
             }
             if (!!this.firstComparison && !!this.booleanOperator) {
-                results = this.filterByComparison(data);
+                results = this.filterByComparison(results);
             }
             filterBy = getFilters('labeler_');
             if (filterBy.length > 0) {