Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Store selected directories in localStorage #277

Merged
merged 8 commits into from
Jan 14, 2025
Merged

Conversation

marySalvi
Copy link
Collaborator

@marySalvi marySalvi commented Nov 21, 2024

Saves the selected directories on update to localStorage and retrieves as the loading default.

@marySalvi marySalvi requested a review from manthey November 21, 2024 17:08
@marySalvi
Copy link
Collaborator Author

@manthey Would we want to clear these from storage at some point and if so under what circumstance?

@manthey
Copy link
Contributor

manthey commented Nov 22, 2024

@manthey Would we want to clear these from storage at some point and if so under what circumstance?

Provided we handle the directories no longer existing, and, in that case default to something sensible, I think it is okay to not delete them.

@manthey
Copy link
Contributor

manthey commented Nov 22, 2024

We should show the images in the input directory if they are present.

@marySalvi marySalvi force-pushed the save-selected-directories branch from b42eb18 to 838623d Compare January 6, 2025 17:34
@manthey
Copy link
Contributor

manthey commented Jan 7, 2025

Probably nothing to do with this PR, but I notice that if I have the input directory dialog open and I click outside of it, it dismisses the dialog, leaves the navigated directory in the input directory field, but doesn't run the plan and show the contents of that directory.

@marySalvi marySalvi force-pushed the save-selected-directories branch from 838623d to 9decd02 Compare January 8, 2025 22:22
@manthey
Copy link
Contributor

manthey commented Jan 14, 2025

Once when messing with this I seem to break the connection between the webpage and the application in that running a redaction failed to update the web progress bar but the terminal showed that it was updating. I don't think it has anything to do with the PR, but we should be on the lookout for it.

And, I think we need to have some sort of progress indicator when we are computing a plan for a directory (since it remains blank for a long time otherwise).

@marySalvi marySalvi merged commit c316c10 into main Jan 14, 2025
4 checks passed
@marySalvi marySalvi deleted the save-selected-directories branch January 14, 2025 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants