Add flexibility for redacting custom DICOM tags #239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replaces the `delete_custom_metadata` option in the rule set with `custom_metadata_action`. This can either be omitted, in which case a rule is needed for each piece of custom metadata in order for the image to be redacted, or set to `"keep"` or `"delete"`. If an action is specified, it will be applied if there is no rule for the custom metadata element.
Exposed a bug where rules were not properly created if the keyword couldn't be determined.
Recent merge from main was broken. Additionally, recent update to maison broke yamlfix. A workaround has been introduced here with a comment pointing to the issue in the yamlfix repo.
manthey
reviewed
Aug 27, 2024
|
|
||
| * `keep`: Retain the custom metadata value after redaction. | ||
| * `delete`: Delete the custom metadata tag from the image. | ||
| * `use_rule`: This mode will fall back to rules specified for each piece of custom metadata in the `metadata` section of the rule set. If a custom metadata tag with no corresponding rule is encountered, the image will not be redacted, as the redaction plan would be considered incomplete. |
There was a problem hiding this comment.
Tag-level rules always apply even with keep or delete, right? If so, we should mention that, too.
There was a problem hiding this comment.
Yes, that is correct. Let me know if the language added in a86c1d2 is clear enough.
manthey
reviewed
Aug 27, 2024
There has been a fix upstream in yamlfix.
manthey
approved these changes
Aug 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #188
Breaking change
Any custom rule sets with
delete_custom_metadataspecified will need to be updated to use the newcustom_metadata_actionoption.Changes
Replaces the
delete_custom_metadataoption in the rule set withcustom_metadata_action. This can either be omitted, in which case a rule is needed for each piece of custom metadata in order for the image to be redacted, or set to"keep"or"delete". If an action is specified, it will be applied if there is no rule for the custom metadata element. This is still only used for DICOM rule sets. The base rule set is configured to delete all custom metadata.TODO