-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Redaction results table #234
Conversation
95bd94c
to
ea9d209
Compare
ea9d209
to
77c413c
Compare
Aside from the progress bar oddity, this looks good. From a feedback issue (not this PR), I wonder if we should leave the list visible behind the progress bar and update each row as redaction occurs (leaving it scrollable or auto-scrolling would be nice, but then we'd have to figure out how to have a blocking progress and scrollable make sense). Also, as another future work, when we select a new directory to redact, we should probably hide the previous directory's listing so that it is is blank (possibly with progress of some sort) until the new directory shows up. For long directories, this can be quite some time without any indication that something is happening or that the current list is no longer relevant. |
@jtomeck Thoughts on how to achieve this? |
fixed in 13a2b6b This was caused by the 'heartbeat' messages resetting the count value. In another PR I will make the ws ping messaging more sophisticated. |
Closes #158
Creates table for redacted image data
Current Workflow:
Screencast.from.07-30-2024.04.17.05.PM.webm