Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redaction results table #234

Merged
merged 6 commits into from
Aug 6, 2024
Merged

Redaction results table #234

merged 6 commits into from
Aug 6, 2024

Conversation

marySalvi
Copy link
Collaborator

@marySalvi marySalvi commented Jul 29, 2024

Closes #158
Creates table for redacted image data
Current Workflow:

  • User Selects an Input Directory
  • A Table is generated with the data generated from a redaction plan for the selected input directory
  • User Selects an Output Directory for the redacted image folder to be created in
  • After reviewing the table the user clicks the 'De-PHI Images' button
  • A pop up appears and reports the progress of redaction
  • When redaction is completed a new table is generated with data generated from the redacted images
  • A dismiss-able toast component appears at the bottom of the page with the location of the redacted images
Screencast.from.07-30-2024.04.17.05.PM.webm

@marySalvi marySalvi force-pushed the redaction-results-table branch from 95bd94c to ea9d209 Compare July 30, 2024 19:41
@marySalvi marySalvi force-pushed the redaction-results-table branch from ea9d209 to 77c413c Compare July 30, 2024 19:58
@marySalvi marySalvi marked this pull request as ready for review July 30, 2024 20:19
@marySalvi marySalvi requested a review from manthey July 30, 2024 20:20
@manthey
Copy link
Contributor

manthey commented Aug 2, 2024

I noticed an odd behavior in the progress meter:
progress
The machine happened to be under fairly heavy load aside from ImageDePHI.

@manthey
Copy link
Contributor

manthey commented Aug 2, 2024

Aside from the progress bar oddity, this looks good.

From a feedback issue (not this PR), I wonder if we should leave the list visible behind the progress bar and update each row as redaction occurs (leaving it scrollable or auto-scrolling would be nice, but then we'd have to figure out how to have a blocking progress and scrollable make sense).

Also, as another future work, when we select a new directory to redact, we should probably hide the previous directory's listing so that it is is blank (possibly with progress of some sort) until the new directory shows up. For long directories, this can be quite some time without any indication that something is happening or that the current list is no longer relevant.

@marySalvi
Copy link
Collaborator Author

From a feedback issue (not this PR), I wonder if we should leave the list visible behind the progress bar and update each row as redaction occurs (leaving it scrollable or auto-scrolling would be nice, but then we'd have to figure out how to have a blocking progress and scrollable make sense).

@jtomeck Thoughts on how to achieve this?

@marySalvi
Copy link
Collaborator Author

I noticed an odd behavior in the progress meter: progress [ ![progress]The machine happened to be under fairly heavy load aside from ImageDePHI.

fixed in 13a2b6b

This was caused by the 'heartbeat' messages resetting the count value. In another PR I will make the ws ping messaging more sophisticated.

@marySalvi marySalvi merged commit 12579fa into main Aug 6, 2024
4 checks passed
@marySalvi marySalvi deleted the redaction-results-table branch August 6, 2024 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reduce confusion at end of workflow
2 participants