round down values in winPosition array #129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vutran
approved these changes
Dec 1, 2016
|
Awesome work! |
|
thanks - not sure 'awesome' is the word - it's just a couple of changes!
…On 1 December 2016 at 18:14, Vu Tran ***@***.***> wrote:
Awesome work!
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#129 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/ACPVYSLut5QCkuMqISniJvhdH8uZ_nwoks5rDw56gaJpZM4LBsAX>
.
|
vutran
pushed a commit
that referenced
this pull request
Jan 5, 2017
* round down values in winPosition array so that they can work as integers for window position * removed errant console.log * revert package.json
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
round down values in winPosition array so that they can work as integers for window position
see #119 (comment)
This works on Linux, hopefully doesn't break any of the other platforms.
rebased off
develop