Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

getMemoryRequirementsForBuffer/Image functions #809

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

Crisspl
Copy link
Collaborator

@Crisspl Crisspl commented Jan 2, 2025

Description

I find them useful, can we have this?

@devshgraphicsprogrammingjenkins
Copy link
Contributor

[CI]: Can one of the admins verify this patch?

@devshgraphicsprogramming
Copy link
Member

But we already have them, here:

inline const SDeviceMemoryRequirements& getMemoryReqs() const {return m_cachedMemoryReqs;}

Both IGPUImage and IGPUBuffer inherit from IDeviceMemoryBacked.

The constructor of IGPUBuffer and IGPUImage are fed with already created VkHandles and the constructor of the base class fills out everything for you.

vk.vkGetBufferMemoryRequirements2(device->getInternalObject(),&vk_memoryRequirementsInfo,&vk_memoryRequirements);

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants