Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Slim healthchecks #200

Merged
merged 2 commits into from
Sep 19, 2024
Merged

Slim healthchecks #200

merged 2 commits into from
Sep 19, 2024

Conversation

jordanstephens
Copy link
Member

@jordanstephens jordanstephens commented Sep 19, 2024 •
edited by github-actions bot
Loading

Fixing up healthchecks for samples with slim images.

The slim images do not come with curl installed, so we need to install it ourselves.

Samples Checklist

✅ All good!

@jordanstephens jordanstephens force-pushed the jordan/slim-healthchecks branch from abea4ea to 8764df9 Compare September 19, 2024 21:39
@jordanstephens jordanstephens merged commit ae8e865 into main Sep 19, 2024
3 checks passed
@lionello
Copy link
Member

@jordanstephens most Dockerfiles appear to have && apt-get clean && rm -f /var/lib/apt/lists/*_* right after the apt-get install

@lionello lionello deleted the jordan/slim-healthchecks branch September 20, 2024 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raphaeltm raphaeltm Awaiting requested review from raphaeltm

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jordanstephens @lionello