Add more logs to tail and service status monitor #518
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Slight restructure of the service monitor and tail code to improve readbablity
edwardrf
changed the title
lionello
requested changes
Jul 2, 2024
edwardrf
commented
Jul 5, 2024
| printEndpoints(serviceInfos) | ||
|
|
||
| if err != nil { | ||
| return err |
There was a problem hiding this comment.
This fixes the detach message regression
edwardrf
commented
Jul 5, 2024
Comment on lines
+835
to
+836
| if !errors.As(err, &cerr) { | ||
| term.Warnf("failed to start tailing, you will not be able to see logs: %v", err) |
There was a problem hiding this comment.
I am on the fence if this warning is needed
edwardrf
commented
Jul 5, 2024
Comment on lines
+24
to
+27
| if !errors.Is(err, context.Canceled) && !errors.Is(err, cli.ErrDryRun) && !errors.As(err, new(cliClient.ErrNotImplemented)) { | ||
| term.Info("Service status monitoring failed, we will continue tailing the logs. Press Ctrl+C to detach.") | ||
| } | ||
| term.Debugf("failed to wait for service status: %v", err) |
There was a problem hiding this comment.
The code would be much simpler if we don't need to log these, but we risk swallow errors for debugging
lionello
reviewed
Jul 5, 2024
| @@ -825,30 +824,25 @@ var composeUpCmd = &cobra.Command{ | |||
| return nil | |||
| } | |||
|
|
|||
| tailCtx, cancelTail := context.WithCancel(ctx) | |||
| tailCtx, cancelTail := contextWithServiceStatus(ctx, cli.ServiceStarted, serviceInfos) | |||
| defer cancelTail() | |||
There was a problem hiding this comment.
how can this happen? startTailing blocks? You do <-Done() so this cancel is just for cleanup, in which case the name is wrong.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And also slight restructure of the service monitor and tail code to improve readability.