Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create sample dir before saving files #511

Merged
merged 1 commit into from
Jun 27, 2024
Merged

Conversation

edwardrf
Copy link
Contributor

No description provided.

@edwardrf edwardrf requested a review from lionello June 27, 2024 04:52
Copy link
Member

@lionello lionello left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How is this different from the Mkdir that’s already there?

@edwardrf
Copy link
Contributor Author

The Mkdir already in there is for creating dir in the sample, e.g. "golang-s3/app", this Mkdir creates golang-s3 in this case, normally this is needed as any subfolder created would create the parent folder in the multiple samples case, but in cases where the first entry in the tarball is a file like "README.md", the parent folder is not created yet.

@edwardrf edwardrf requested a review from lionello June 27, 2024 05:15
@lionello lionello merged commit 060f18a into main Jun 27, 2024
5 checks passed
@lionello lionello deleted the edw-load-sample-create-dir branch June 27, 2024 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants