Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make project optional for CD #504

Merged
merged 1 commit into from
Jun 26, 2024
Merged

make project optional for CD #504

merged 1 commit into from
Jun 26, 2024

Conversation

lionello
Copy link
Member

@lionello lionello commented Jun 26, 2024

Better fix for MVP CI failure https://github.com/DefangLabs/defang-mvp/actions/runs/9653599270/job/26626547585#step:6:46 (that test should not have to set COMPOSE_PROJECT_NAME at all)

@lionello lionello requested a review from edwardrf June 26, 2024 17:48
@lionello lionello force-pushed the lio-cd-list-without-project branch from 0d8395e to b704463 Compare June 26, 2024 17:50
Copy link
Contributor

@edwardrf edwardrf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lionello lionello merged commit 927b7a7 into main Jun 26, 2024
5 checks passed
@lionello lionello deleted the lio-cd-list-without-project branch June 26, 2024 23:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants