test cleanup

DefangLabs · Jun 25, 2024 · 58c7428 · 58c7428
1 parent 90c6f99
commit 58c7428
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 10 deletions.
diff --git a/src/pkg/cli/tail_test.go b/src/pkg/cli/tail_test.go
@@ -74,9 +74,9 @@ func TestTail(t *testing.T) {
 	DoVerbose = true // Output host
 	defaultTerm := term.DefaultTerm
 	term.DefaultTerm = testTerm
-	defer func() {
+	t.Cleanup(func() {
 		term.DefaultTerm = defaultTerm
-	}()
+	})
 
 	proj, err := ComposeLoader{"../../tests/testproj/compose.yaml"}.LoadCompose(context.Background())
 	if err != nil {

diff --git a/src/pkg/term/colorizer_test.go b/src/pkg/term/colorizer_test.go
@@ -69,10 +69,10 @@ func TestStripAnsi(t *testing.T) {
 }
 
 func TestAddingPrefix(t *testing.T) {
-	currentTerm := DefaultTerm
-	defer func() {
-		DefaultTerm = currentTerm
-	}()
+	defaultTerm := DefaultTerm
+	t.Cleanup(func() {
+		DefaultTerm = defaultTerm
+	})
 	var stdout, stderr bytes.Buffer
 	DefaultTerm = NewTerm(&stdout, &stderr)
 	DefaultTerm.SetDebug(true)
@@ -119,10 +119,10 @@ func TestAddingPrefix(t *testing.T) {
 }
 
 func TestInfoAddSpaceBetweenStrings(t *testing.T) {
-	currentTerm := DefaultTerm
-	defer func() {
-		DefaultTerm = currentTerm
-	}()
+	defaultTerm := DefaultTerm
+	t.Cleanup(func() {
+		DefaultTerm = defaultTerm
+	})
 	var stdout, stderr bytes.Buffer
 	DefaultTerm = NewTerm(&stdout, &stderr)
 	DefaultTerm.SetDebug(true)
@@ -150,3 +150,9 @@ func TestInfoAddSpaceBetweenStrings(t *testing.T) {
 		t.Errorf("Expected stderr to be empty, got %q", stderr.String())
 	}
 }
+
+func TestIsTerminal(t *testing.T) {
+	if IsTerminal() {
+		t.Error("Expected IsTerminal() to return false")
+	}
+}