allow empty source

src/pkg/cli/compose/loader_test.go

@@ -49,16 +49,18 @@ func compare(actual []byte, goldenFile string) error {
 func diff(actualRaw, goldenRaw string) error {
 	linesActual := strings.Split(actualRaw, "\n")
 	linesGolden := strings.Split(goldenRaw, "\n")
+	var prev string
 	for i, actual := range linesActual {
 		if i >= len(linesGolden) {
-			return fmt.Errorf("+ expected - actual\n+EOF\n-%s", actual)
+			return fmt.Errorf("+ expected - actual\n%s+EOF\n-%s", prev, actual)
 		}
 		if actual != linesGolden[i] {
-			return fmt.Errorf("+ expected - actual\n+%s\n-%s", linesGolden[i], actual)
+			return fmt.Errorf("+ expected - actual\n%s+%s\n-%s", prev, linesGolden[i], actual)
 		}
+		prev = " " + actual + "\n"
 	}
 	if len(linesActual) < len(linesGolden) {
-		return fmt.Errorf("+ expected - actual\n+%s\n-EOF", linesGolden[len(linesActual)])
+		return fmt.Errorf("+ expected - actual\n%s+%s\n-EOF", prev, linesGolden[len(linesActual)])
 	}
 	return nil
 }

src/pkg/cli/compose/validation.go

@@ -94,9 +94,10 @@ func ValidateProject(project *compose.Project) error {
 		for _, v := range svccfg.Volumes {
 			if v.Type != "volume" {
 				warnf("service %q: unsupported volume type: %q", svccfg.Name, v.Type)
-				continue
+				continue // TODO: ignore or error?
 			}
-			if _, ok := project.Volumes[v.Source]; !ok {
+			// Source=="" is allowed for anonymous volumes (will generate a random name)
+			if _, ok := project.Volumes[v.Source]; !ok && v.Source != "" {
 				warnf("service %q: volume %q is not defined in the top-level volumes section", svccfg.Name, v.Source)
 			}
 		}

src/protos/io/defang/v1/fabric.proto

@@ -356,7 +356,7 @@ message Service {
 }
 
 message Volume {
-  string source = 1; // name of the volume
+  string source = 1; // name of the volume; empty for anonymous volumes
   string target = 2; // path in the container
   bool read_only = 3;
 }

src/tests/volumes/compose.yaml

@@ -0,0 +1,14 @@
+services:
+  volume1:
+    image: busybox
+    volumes:
+      - tmp:/tmp
+  volume2:
+    image: busybox
+    volumes:
+      - target: /tmp
+        read_only: true
+        type: volume
+
+volumes:
+  tmp:

src/tests/volumes/compose.yaml.convert

@@ -0,0 +1,28 @@
+[
+  {
+    "name": "volume1",
+    "image": "busybox",
+    "platform": 2,
+    "internal": true,
+    "networks": 1,
+    "volumes": [
+      {
+        "source": "tmp",
+        "target": "/tmp"
+      }
+    ]
+  },
+  {
+    "name": "volume2",
+    "image": "busybox",
+    "platform": 2,
+    "internal": true,
+    "networks": 1,
+    "volumes": [
+      {
+        "target": "/tmp",
+        "read_only": true
+      }
+    ]
+  }
+]

src/tests/volumes/compose.yaml.golden

@@ -0,0 +1,25 @@
+name: volumes
+services:
+  volume1:
+    image: busybox
+    networks:
+      default: null
+    volumes:
+      - type: volume
+        source: tmp
+        target: /tmp
+        volume: {}
+  volume2:
+    image: busybox
+    networks:
+      default: null
+    volumes:
+      - type: volume
+        target: /tmp
+        read_only: true
+networks:
+  default:
+    name: volumes_default
+volumes:
+  tmp:
+    name: volumes_tmp

src/tests/volumes/compose.yaml.warnings

@@ -0,0 +1,4 @@
+level=warning msg="service \"volume1\": missing compose directive: restart; assuming 'unless-stopped' (add 'restart' to silence)"
+level=warning msg="service \"volume1\": missing memory reservation; specify deploy.resources.reservations.memory to avoid out-of-memory errors"
+level=warning msg="service \"volume2\": missing compose directive: restart; assuming 'unless-stopped' (add 'restart' to silence)"
+level=warning msg="service \"volume2\": missing memory reservation; specify deploy.resources.reservations.memory to avoid out-of-memory errors"