-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added 1-Click Deploy tutorial #160
Conversation
Co-authored-by: Jordan Stephens <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly looks good. Pls see specific comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work.
See detailed comments.
title: Adding a Custom 1-Click Deploy | ||
sidebar_position: 800 | ||
description: Add a custom 1-Click Deploy button to deploy your own app. | ||
--- | ||
|
||
# Adding a Custom 1-Click Deploy |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This title feels a little indirect. What do you think about something like this:
title: Adding a Custom 1-Click Deploy | |
sidebar_position: 800 | |
description: Add a custom 1-Click Deploy button to deploy your own app. | |
--- | |
# Adding a Custom 1-Click Deploy | |
title: Using 1-Click Deploy With Your Project | |
sidebar_position: 800 | |
description: Add a custom 1-Click Deploy button to deploy your own app. | |
--- | |
# Using 1-Click Deploy With Your Project |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried to make the title as different from the "Using 1-Click Deploy" tutorial as possible, so that it's clear for new users which one to look for first. Maybe "Adding Custom 1-Click Deploy to an App" will be a better alternative?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about "Adding Custom 1-Click Deploy to your App"?
Or "Deploying Your App with 1-click Deploy"
Co-authored-by: Jordan Stephens <[email protected]>
|
||
This tutorial will show you how to use Defang 1-Click Deploy to deploy a sample to the Defang Playground. | ||
|
||
The 1-Click Deploy button is intended to be a quickstart way for new users to deploy to the [Defang Playground](/docs/concepts/defang-playground) with no prior installation of the CLI needed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What do you think about this? "quickstart way" felt a little ambiguous.
The 1-Click Deploy button is intended to be a quickstart way for new users to deploy to the [Defang Playground](/docs/concepts/defang-playground) with no prior installation of the CLI needed. | |
The 1-Click Deploy button is intended to be a quickstart guide to deploying an application to the [Defang Playground](/docs/concepts/defang-playground) with no prior installation of the CLI needed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The button itself isn't a guide (as in an explicit tutorial) though, it's almost like a shortcut. Also, I think we should keep the word "new users" somewhere to make the distinction extremely clear between the other tutorial.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do agree we can use a better wording than "way"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ohh duh. Once again, not reading in the mindset of the reader.Maybe it would be better to come on a bit more confidently, and say something like this, but it's not super important.
The 1-Click Deploy button is intended to be a quickstart way for new users to deploy to the [Defang Playground](/docs/concepts/defang-playground) with no prior installation of the CLI needed. | |
The 1-Click Deploy button is the easiest way for new users to deploy your project to the [Defang Playground](/docs/concepts/defang-playground). No CLI installation is required. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This sentence is part of the tutorial for brand-new users, so it should not say "for new users to deploy your project". I agree with the other changes here though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Made a few quick suggestions inline to tighten it up a little bit further, but this is looking excellent. Thank you Linda!
Co-authored-by: Jordan Stephens <[email protected]>
Co-authored-by: Jordan Stephens <[email protected]>
…s/defang-docs into linda-one-click-deploy
Fixes #161