-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add SARIF parser #3
Conversation
}, | ||
}, | ||
{ | ||
"issue_code": "container-resources", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this made up, or are we missing this in the mapping?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, that is made up. sarif-parser
tests don't deal with real world mappings. Tests regarding that will be in the top level tests
folder.
Also, set up test coverage reporting? |
Don't have the perms to set secrets on this repo.
Can you give an actual kube linter artifact? I'll write a test against that.
I think it only catches it if it's |
Added
Can you verify and create issue? It should catch blanket TODOs as well. |
It does get raised on def foo():
pass # TODO $ python -m marvin_py -sl /tmp/code/**/*.py
{"path": "/tmp/code/a.py", "line": 1, "column": 0, "message-id": "PYL-C0104", "message": "Disallowed name \"foo\"", "context": null}
{"path": "/tmp/code/a.py", "line": 2, "column": 10, "message-id": "PYL-W0511", "message": "TODO", "context": null} |
Signed-off-by: Tushar Sadhwani <[email protected]>
Signed-off-by: Tushar Sadhwani <[email protected]>
Signed-off-by: Tushar Sadhwani <[email protected]>
sarif-parser
packaage, with tests and a CLI.run_community_analyzer.py
which passes the correctissue_map.json
, and a test for artifacts.