Fix and update vllm-based GRPO Trainer implementation #85
+841
−10
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to fix the problems in the original vllm-based grpo trainer implementation, a new trainer
Qwen2VLGRPOVLLMTrainerModified
is provided (located insrc/open-r1-multimodal/src/open_r1/trainer/vllm_grpo_trainer_modified.py
).It no longer uses
RepeatRandomSampler
to avoid the issue of training steps doubling. Instead, it completes multiple sampling and loss calculations for each prompt within a single original batch, maintaining consistency with the logic ofQwen2VLGRPOTrainer
. Additionally, it no longer requiresnum_generations
to match the number of GPUs.Qwen2VLGRPOVLLMTrainer
insrc/open-r1-multimodal/src/open_r1/grpo.py
.