Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Google Protobuf Instrumentation #6166

Open
wants to merge 15 commits into
base: master
Choose a base branch
from
Open

Add Google Protobuf Instrumentation #6166

wants to merge 15 commits into from

Conversation

vandonr
Copy link
Contributor

@vandonr vandonr commented Oct 18, 2024 •
edited
Loading

Summary of changes

Adds a new instrumentation for Google Protobuf (not https://github.com/protobuf-net/protobuf-net)
The instrumentation doesn't create any new spans, we are just adding tags on existing ones. The main one being a tag containing the full protobuf schema as an OpenAPI json. Since extracting the schema is costly, we only do it once every 30 seconds (hardcoded for now).

Reason for change

On request from DSM team, as an equivalent of its java counterpart: https://github.com/DataDog/dd-trace-java/tree/master/dd-java-agent/instrumentation/protobuf

Implementation details

  • There is a cache <schema name -> schema json>, but I wanted to control the size, so I ended up repurposing the code that had been written for DbConnectionCache, where it's using a cache for small cardinality, but if there are too many different values, it stops caching.
  • I wrote a rate limiter rather than reusing one because to avoid forcing the sampling decision on every span, I needed one where I can peek the rate limit decision without "consuming" it.

Test coverage

Added a sample app that serializes and deserializes a protobuf message. Spans are created manually since this integration doesn't create one.

Other details

@datadog-ddstaging
Copy link

datadog-ddstaging bot commented Oct 18, 2024 •
edited
Loading

Datadog Report

Branch report: vandonr/proto
Commit report: 3236d38
Test service: dd-trace-dotnet

✅ 0 Failed, 558477 Passed, 4621 Skipped, 46h 31m 20.16s Total Time

@andrewlock
Copy link
Member

andrewlock commented Oct 18, 2024 •
edited
Loading

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing the following branches/commits:

Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:

  • Welch test with statistical test for significance of 5%
  • Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6166) - mean (69ms)  : 66, 72
     .   : milestone, 69,
    master - mean (69ms)  : 67, 71
     .   : milestone, 69,

    section CallTarget+Inlining+NGEN
    This PR (6166) - mean (981ms)  : 963, 1000
     .   : milestone, 981,
    master - mean (983ms)  : 958, 1007
     .   : milestone, 983,
Loading 
gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6166) - mean (107ms)  : 105, 109
     .   : milestone, 107,
    master - mean (108ms)  : 106, 110
     .   : milestone, 108,

    section CallTarget+Inlining+NGEN
    This PR (6166) - mean (684ms)  : 674, 695
     .   : milestone, 684,
    master - mean (683ms)  : 665, 700
     .   : milestone, 683,
Loading 
gantt
    title Execution time (ms) FakeDbCommand (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6166) - mean (91ms)  : 89, 93
     .   : milestone, 91,
    master - mean (91ms)  : 89, 93
     .   : milestone, 91,

    section CallTarget+Inlining+NGEN
    This PR (6166) - mean (636ms)  : 620, 652
     .   : milestone, 636,
    master - mean (637ms)  : 619, 656
     .   : milestone, 637,
Loading 
gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6166) - mean (189ms)  : 185, 194
     .   : milestone, 189,
    master - mean (190ms)  : 185, 195
     .   : milestone, 190,

    section CallTarget+Inlining+NGEN
    This PR (6166) - mean (1,088ms)  : 1051, 1125
     .   : milestone, 1088,
    master - mean (1,089ms)  : 1052, 1126
     .   : milestone, 1089,
Loading 
gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6166) - mean (275ms)  : 271, 279
     .   : milestone, 275,
    master - mean (276ms)  : 271, 282
     .   : milestone, 276,

    section CallTarget+Inlining+NGEN
    This PR (6166) - mean (871ms)  : 843, 899
     .   : milestone, 871,
    master - mean (873ms)  : 843, 903
     .   : milestone, 873,
Loading 
gantt
    title Execution time (ms) HttpMessageHandler (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6166) - mean (263ms)  : 260, 267
     .   : milestone, 263,
    master - mean (264ms)  : 259, 269
     .   : milestone, 264,

    section CallTarget+Inlining+NGEN
    This PR (6166) - mean (848ms)  : 809, 887
     .   : milestone, 848,
    master - mean (849ms)  : 821, 876
     .   : milestone, 849,
Loading

@andrewlock
Copy link
Member

andrewlock commented Oct 18, 2024 •
edited
Loading

Throughput/Crank Report ⚡

Throughput results for AspNetCoreSimpleController comparing the following branches/commits:

Cases where throughput results for the PR are worse than latest master (5% drop or greater), results are shown in red.

Note that these results are based on a single point-in-time result for each branch. For full results, see one of the many, many dashboards!

gantt
    title Throughput Linux x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (6166) (11.162M)   : 0, 11161793
    master (11.223M)   : 0, 11223304
    benchmarks/2.9.0 (11.045M)   : 0, 11045405

    section Automatic
    This PR (6166) (7.265M)   : 0, 7264852
    master (7.369M)   : 0, 7368879
    benchmarks/2.9.0 (7.885M)   : 0, 7885346

    section Trace stats
    master (7.636M)   : 0, 7635764

    section Manual
    master (11.208M)   : 0, 11208283

    section Manual + Automatic
    This PR (6166) (6.810M)   : 0, 6810342
    master (6.860M)   : 0, 6860273

    section DD_TRACE_ENABLED=0
    master (10.386M)   : 0, 10385517
Loading 
gantt
    title Throughput Linux arm64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (6166) (9.764M)   : 0, 9764307
    master (9.546M)   : 0, 9546423
    benchmarks/2.9.0 (9.586M)   : 0, 9586476

    section Automatic
    This PR (6166) (6.449M)   : 0, 6448736
    master (6.583M)   : 0, 6583133

    section Trace stats
    master (6.861M)   : 0, 6860986

    section Manual
    master (9.767M)   : 0, 9766866

    section Manual + Automatic
    This PR (6166) (5.942M)   : 0, 5941979
    master (5.972M)   : 0, 5972206

    section DD_TRACE_ENABLED=0
    master (8.948M)   : 0, 8947586
Loading 
gantt
    title Throughput Windows x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (6166) (9.861M)   : 0, 9861124

    section Automatic
    This PR (6166) (6.395M)   : 0, 6394947

    section Manual + Automatic
    This PR (6166) (5.984M)   : 0, 5983994
Loading

@andrewlock
Copy link
Member

andrewlock commented Oct 18, 2024 •
edited
Loading

Benchmarks Report for tracer 🐌

Benchmarks for #6166 compared to master:

  • 1 benchmarks are faster, with geometric mean 1.189
  • 2 benchmarks are slower, with geometric mean 1.151
  • 1 benchmarks have fewer allocations

The following thresholds were used for comparing the benchmark speeds:

  • Mann–Whitney U test with statistical test for significance of 5%
  • Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.ActivityBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartStopWithChild net6.0 7.88μs 43.9ns 297ns 0.015 0.0075 0 5.61 KB
master StartStopWithChild netcoreapp3.1 10.2μs 51.6ns 242ns 0.0193 0.00963 0 5.8 KB
master StartStopWithChild net472 16.1μs 53.7ns 208ns 1.04 0.303 0.0957 6.2 KB
#6166 StartStopWithChild net6.0 7.88μs 44.8ns 307ns 0.0159 0.00793 0 5.61 KB
#6166 StartStopWithChild netcoreapp3.1 9.76μs 51ns 302ns 0.0187 0.00933 0 5.81 KB
#6166 StartStopWithChild net472 16μs 54.7ns 212ns 1.06 0.329 0.102 6.21 KB
Benchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 485μs 157ns 545ns 0 0 0 2.7 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 647μs 452ns 1.69μs 0 0 0 2.7 KB
master WriteAndFlushEnrichedTraces net472 864μs 505ns 1.95μs 0.425 0 0 3.3 KB
#6166 WriteAndFlushEnrichedTraces net6.0 484μs 189ns 732ns 0 0 0 2.7 KB
#6166 WriteAndFlushEnrichedTraces netcoreapp3.1 642μs 224ns 839ns 0 0 0 2.7 KB
#6166 WriteAndFlushEnrichedTraces net472 855μs 474ns 1.84μs 0.422 0 0 3.3 KB
Benchmarks.Trace.AspNetCoreBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendRequest net6.0 128μs 533ns 2.06μs 0.187 0 0 14.47 KB
master SendRequest netcoreapp3.1 147μs 131ns 492ns 0.216 0 0 17.27 KB
master SendRequest net472 0.01ns 0.00339ns 0.0131ns 0 0 0 0 b
#6166 SendRequest net6.0 130μs 341ns 1.32μs 0.131 0 0 14.47 KB
#6166 SendRequest netcoreapp3.1 147μs 210ns 814ns 0.222 0 0 17.27 KB
#6166 SendRequest net472 0.000551ns 0.000486ns 0.00188ns 0 0 0 0 b
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed ✔️ Fewer allocations 🎉

Fewer allocations 🎉 in #6166

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces‑net6.0 41.77 KB 41.42 KB -345 B -0.83%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 551μs 2.26μs 8.77μs 0.548 0 0 41.77 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 663μs 3.53μs 18.3μs 0.332 0 0 41.85 KB
master WriteAndFlushEnrichedTraces net472 824μs 3.66μs 14.2μs 8.12 2.44 0.406 53.26 KB
#6166 WriteAndFlushEnrichedTraces net6.0 552μs 2.7μs 11.1μs 0.548 0 0 41.42 KB
#6166 WriteAndFlushEnrichedTraces netcoreapp3.1 645μs 3.26μs 14.6μs 0.327 0 0 41.64 KB
#6166 WriteAndFlushEnrichedTraces net472 819μs 2.72μs 10.2μs 8.36 2.39 0.398 53.27 KB
Benchmarks.Trace.DbCommandBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteNonQuery net6.0 1.38μs 0.823ns 3.19ns 0.0141 0 0 1.02 KB
master ExecuteNonQuery netcoreapp3.1 1.78μs 2.92ns 10.9ns 0.0133 0 0 1.02 KB
master ExecuteNonQuery net472 2.06μs 1.36ns 4.89ns 0.156 0.00103 0 987 B
#6166 ExecuteNonQuery net6.0 1.3μs 1.4ns 5.4ns 0.0138 0 0 1.02 KB
#6166 ExecuteNonQuery netcoreapp3.1 1.72μs 5.84ns 22.6ns 0.0137 0 0 1.02 KB
#6166 ExecuteNonQuery net472 1.98μs 3.68ns 13.8ns 0.157 0.000986 0 987 B
Benchmarks.Trace.ElasticsearchBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master CallElasticsearch net6.0 1.25μs 0.675ns 2.53ns 0.0138 0 0 976 B
master CallElasticsearch netcoreapp3.1 1.64μs 0.841ns 2.92ns 0.0132 0 0 976 B
master CallElasticsearch net472 2.56μs 1.11ns 4.16ns 0.157 0 0 995 B
master CallElasticsearchAsync net6.0 1.31μs 0.601ns 2.25ns 0.0131 0 0 952 B
master CallElasticsearchAsync netcoreapp3.1 1.58μs 1.15ns 4.44ns 0.0133 0 0 1.02 KB
master CallElasticsearchAsync net472 2.62μs 1.08ns 4.05ns 0.167 0 0 1.05 KB
#6166 CallElasticsearch net6.0 1.39μs 0.685ns 2.56ns 0.0132 0 0 976 B
#6166 CallElasticsearch netcoreapp3.1 1.66μs 0.606ns 2.27ns 0.0133 0 0 976 B
#6166 CallElasticsearch net472 2.53μs 1.36ns 5.28ns 0.158 0 0 995 B
#6166 CallElasticsearchAsync net6.0 1.42μs 0.796ns 2.98ns 0.0129 0 0 952 B
#6166 CallElasticsearchAsync netcoreapp3.1 1.55μs 1.29ns 4.82ns 0.0142 0 0 1.02 KB
#6166 CallElasticsearchAsync net472 2.75μs 0.903ns 3.5ns 0.167 0 0 1.05 KB
Benchmarks.Trace.GraphQLBenchmark - Slower ⚠️ Same allocations ✔️

Slower ⚠️ in #6166

Benchmark diff/base Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.GraphQLBenchmark.ExecuteAsync‑net6.0 1.114 1,200.77 1,337.07

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteAsync net6.0 1.2μs 0.741ns 2.87ns 0.0134 0 0 952 B
master ExecuteAsync netcoreapp3.1 1.71μs 1.01ns 3.78ns 0.0126 0 0 952 B
master ExecuteAsync net472 1.78μs 0.305ns 1.1ns 0.145 0 0 915 B
#6166 ExecuteAsync net6.0 1.34μs 0.552ns 2.06ns 0.0134 0 0 952 B
#6166 ExecuteAsync netcoreapp3.1 1.58μs 0.528ns 1.98ns 0.0127 0 0 952 B
#6166 ExecuteAsync net472 1.84μs 0.642ns 2.48ns 0.145 0 0 915 B
Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendAsync net6.0 4.18μs 1.36ns 5.1ns 0.0314 0 0 2.31 KB
master SendAsync netcoreapp3.1 5.24μs 2.64ns 9.53ns 0.0364 0 0 2.85 KB
master SendAsync net472 7.38μs 1.68ns 6.52ns 0.494 0 0 3.12 KB
#6166 SendAsync net6.0 4.55μs 2.95ns 11.4ns 0.0321 0 0 2.31 KB
#6166 SendAsync netcoreapp3.1 5.25μs 1.85ns 6.91ns 0.0394 0 0 2.85 KB
#6166 SendAsync net472 7.54μs 1.94ns 7.53ns 0.494 0 0 3.12 KB
Benchmarks.Trace.ILoggerBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 1.45μs 0.621ns 2.24ns 0.0233 0 0 1.64 KB
master EnrichedLog netcoreapp3.1 2.41μs 1.28ns 4.96ns 0.0216 0 0 1.64 KB
master EnrichedLog net472 2.5μs 1.26ns 4.88ns 0.25 0 0 1.57 KB
#6166 EnrichedLog net6.0 1.47μs 0.704ns 2.64ns 0.023 0 0 1.64 KB
#6166 EnrichedLog netcoreapp3.1 2.17μs 1.11ns 4ns 0.0216 0 0 1.64 KB
#6166 EnrichedLog net472 2.52μs 0.533ns 1.99ns 0.25 0 0 1.57 KB
Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 116μs 129ns 499ns 0 0 0 4.28 KB
master EnrichedLog netcoreapp3.1 120μs 123ns 461ns 0.0601 0 0 4.28 KB
master EnrichedLog net472 152μs 189ns 733ns 0.682 0.227 0 4.46 KB
#6166 EnrichedLog net6.0 115μs 126ns 487ns 0.0574 0 0 4.28 KB
#6166 EnrichedLog netcoreapp3.1 120μs 105ns 392ns 0 0 0 4.28 KB
#6166 EnrichedLog net472 152μs 107ns 413ns 0.683 0.228 0 4.46 KB
Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 3.08μs 0.764ns 2.86ns 0.0308 0 0 2.2 KB
master EnrichedLog netcoreapp3.1 4.26μs 2.26ns 8.76ns 0.0297 0 0 2.2 KB
master EnrichedLog net472 4.79μs 1.86ns 7.22ns 0.32 0 0 2.02 KB
#6166 EnrichedLog net6.0 3.02μs 1.35ns 5.21ns 0.0303 0 0 2.2 KB
#6166 EnrichedLog netcoreapp3.1 4.13μs 1.06ns 4.09ns 0.029 0 0 2.2 KB
#6166 EnrichedLog net472 4.93μs 0.861ns 3.1ns 0.32 0 0 2.02 KB
Benchmarks.Trace.RedisBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendReceive net6.0 1.36μs 0.575ns 2.23ns 0.0163 0 0 1.14 KB
master SendReceive netcoreapp3.1 1.81μs 3.43ns 12.8ns 0.015 0 0 1.14 KB
master SendReceive net472 2.06μs 0.783ns 2.82ns 0.183 0 0 1.16 KB
#6166 SendReceive net6.0 1.39μs 1.17ns 4.52ns 0.0159 0 0 1.14 KB
#6166 SendReceive netcoreapp3.1 1.85μs 1.07ns 4.13ns 0.0148 0 0 1.14 KB
#6166 SendReceive net472 2.15μs 2.16ns 8.38ns 0.183 0 0 1.16 KB
Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 2.78μs 3.01ns 11.3ns 0.0223 0 0 1.6 KB
master EnrichedLog netcoreapp3.1 3.86μs 6.13ns 23.7ns 0.0211 0 0 1.65 KB
master EnrichedLog net472 4.35μs 2.39ns 9.24ns 0.323 0 0 2.04 KB
#6166 EnrichedLog net6.0 2.89μs 0.874ns 3.38ns 0.0221 0 0 1.6 KB
#6166 EnrichedLog netcoreapp3.1 3.95μs 3.78ns 14.6ns 0.0217 0 0 1.65 KB
#6166 EnrichedLog net472 4.56μs 1.5ns 5.83ns 0.324 0 0 2.04 KB
Benchmarks.Trace.SpanBenchmark - Slower ⚠️ Same allocations ✔️

Slower ⚠️ in #6166

Benchmark diff/base Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.SpanBenchmark.StartFinishScope‑net6.0 1.189 488.69 581.17

Faster 🎉 in #6166

Benchmark base/diff Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.SpanBenchmark.StartFinishSpan‑net6.0 1.189 466.99 392.60

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartFinishSpan net6.0 467ns 0.582ns 2.25ns 0.00817 0 0 576 B
master StartFinishSpan netcoreapp3.1 613ns 1.03ns 4.01ns 0.0077 0 0 576 B
master StartFinishSpan net472 647ns 1.09ns 4.22ns 0.0916 0 0 578 B
master StartFinishScope net6.0 489ns 0.485ns 1.88ns 0.00966 0 0 696 B
master StartFinishScope netcoreapp3.1 697ns 1.31ns 5.06ns 0.00946 0 0 696 B
master StartFinishScope net472 868ns 1.64ns 6.34ns 0.104 0 0 658 B
#6166 StartFinishSpan net6.0 393ns 0.706ns 2.73ns 0.00813 0 0 576 B
#6166 StartFinishSpan netcoreapp3.1 592ns 0.863ns 3.34ns 0.00781 0 0 576 B
#6166 StartFinishSpan net472 616ns 0.654ns 2.53ns 0.0917 0 0 578 B
#6166 StartFinishScope net6.0 582ns 1.21ns 4.68ns 0.00975 0 0 696 B
#6166 StartFinishScope netcoreapp3.1 719ns 1.07ns 4.13ns 0.00943 0 0 696 B
#6166 StartFinishScope net472 843ns 2.22ns 8.58ns 0.104 0 0 658 B
Benchmarks.Trace.TraceAnnotationsBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master RunOnMethodBegin net6.0 693ns 1.63ns 6.31ns 0.00976 0 0 696 B
master RunOnMethodBegin netcoreapp3.1 910ns 1.74ns 6.73ns 0.00905 0 0 696 B
master RunOnMethodBegin net472 1.04μs 3.03ns 11.7ns 0.104 0 0 658 B
#6166 RunOnMethodBegin net6.0 682ns 0.807ns 3.02ns 0.00972 0 0 696 B
#6166 RunOnMethodBegin netcoreapp3.1 916ns 1.56ns 5.85ns 0.00916 0 0 696 B
#6166 RunOnMethodBegin net472 1.05μs 1.9ns 7.36ns 0.104 0 0 658 B

@vandonr vandonr marked this pull request as ready for review December 18, 2024 16:29
@vandonr vandonr requested review from a team as code owners December 18, 2024 16:29
@vandonr vandonr changed the base branch from master to vandonr/vendored December 19, 2024 09:58
@vandonr vandonr mentioned this pull request Dec 30, 2024
Merged
@vandonr vandonr added type:bug area:tests unit tests, integration tests area:integrations and removed type:bug area:tests unit tests, integration tests labels Dec 30, 2024
vandonr added a commit that referenced this pull request Jan 14, 2025
@vandonr @bouwkast
Vendor in Microsoft.OpenApi (#6461)
5393598 
## Summary of changes

added the code of Microsoft.OpenApi to the tracer, removed/changed the
parts that require more recent versions of the language/fwk than we
have, and updated generated files.

## Reason for change

It's going to be needed for the protobuf instrumentation in #6166, and
I'm doing it in a separate PR to limit the size of the diff in the
actual change.

## Implementation details

@bouwkast ran the vendoring tool to add the files, since it's not
working on Mac apparently

## Test coverage

## Other details

When looking at the size of artefacts published on the CI, it looks like
this is increasing the size of the dll by ~180KiB

<!-- ⚠️ Note: where possible, please obtain 2 approvals prior to
merging. Unless CODEOWNERS specifies otherwise, for external teams it is
typically best to have one review from a team member, and one review
from apm-dotnet. Trivial changes do not require 2 reviews. -->

---------

Co-authored-by: Steven Bouwkamp <[email protected]>
Base automatically changed from vandonr/vendored to master January 14, 2025 10:41
@vandonr vandonr mentioned this pull request Jan 14, 2025
Merged
@datadog-ddstaging
Copy link

datadog-ddstaging bot commented Jan 23, 2025 •
edited
Loading

Datadog Report

Branch report: vandonr/proto
Commit report: 4aaaa0f
Test service: dd-trace-dotnet

❌ 48 Failed (0 Known Flaky), 553168 Passed, 4607 Skipped, 44h 11m 37.13s Total Time

❌ Failed Tests (48)

This report shows up to 5 failed tests.

  • TagTraces - Datadog.Trace.ClrProfiler.IntegrationTests.GoogleProtobufTests - Details

    Expand for error 
     application not found: /project/artifacts/bin/Samples.GoogleProtobuf/release_net9.0/Samples.GoogleProtobuf.dll

  • TagTraces - Datadog.Trace.ClrProfiler.IntegrationTests.GoogleProtobufTests - Details

    Expand for error 
     application not found: /project/artifacts/bin/Samples.GoogleProtobuf/release_net8.0/Samples.GoogleProtobuf.dll

  • TagTraces - Datadog.Trace.ClrProfiler.IntegrationTests.GoogleProtobufTests - Details

    Expand for error 
     application not found: /project/artifacts/bin/Samples.GoogleProtobuf/release_net8.0/Samples.GoogleProtobuf.dll

  • TagTraces - Datadog.Trace.ClrProfiler.IntegrationTests.GoogleProtobufTests - Details

    Expand for error 
     application not found: /project/artifacts/bin/Samples.GoogleProtobuf/release_net9.0/Samples.GoogleProtobuf.dll

  • TagTraces - Datadog.Trace.ClrProfiler.IntegrationTests.GoogleProtobufTests - Details

    Expand for error 
     application not found: /project/artifacts/bin/Samples.GoogleProtobuf/release_net9.0/Samples.GoogleProtobuf.dll

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
area:integrations
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vandonr @andrewlock