-
Notifications
You must be signed in to change notification settings - Fork 145
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Move the Nuke arguments into the gitlab file (#6611)
## Summary of changes Allow specifying the Nuke targets to run in the gitlab file ## Reason for change Currently they're baked into the build image. That means if we need to change the args, we need to build a whole new image ## Implementation details Pass the arguments as commands in the `docker run` call. These get passed as arguments to the `entrypoint.bat` script. The script then reads the args and splats them into the Nuke call. ## Test coverage I've tested the splatting, but an end-to-end test requires rebuilding the image. The good news is that this change works with the old image (it's a no-op) so it's safe to merge anyway. ## Other details That docker line was getting a bit hefty, so split it for "readability"
- Loading branch information
1 parent
80f33bc
commit 642f1cb
Showing
3 changed files
with
22 additions
and
4 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters