-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
propagate Properties common to all Representations to MediaInfo #4682
propagate Properties common to all Representations to MediaInfo #4682
Conversation
A few open questions:
@dsilhavy : Let me know what you think... (question 1 only) |
Just figured out, we have duplicated code that could be avoided: Likewise in |
I suggest we keep both
I would like to keep dedicated functions exposed to the outside. So |
Thanks for the review! "Common" was indeed misleading, I like "combined" ;-) |
Thanks, Stephan, that looks good. One minor variable naming change would be nice (see my latest review comments). Please also move the functions upwards as suggested by you. |
This PR re-establishes the use case that Supplemental- and EssentialProperties can be assigned to either AdaptationSets or Representations.