Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ROCm port #11

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

ROCm port #11

wants to merge 2 commits into from

Conversation

jeffdaily
Copy link

Tests verified as passing on MI200. Benchmarking TBD.

@jeffdaily jeffdaily changed the title Rocm ROCm port Nov 19, 2024
caffe3
caffe3 reviewed Nov 19, 2024
View reviewed changes
csrc/fast_hadamard_transform_common.h
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had to also add:

#ifndef USE_ROCM
#include <cuda_bf16.h>
#endif

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah, must be dependent on rocm version. I was using 6.2 and didn't need to add that.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah yes, I'm using 6.1.3 currently

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@caffe3 caffe3 caffe3 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jeffdaily @caffe3