Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the pyproject.toml and set fail-under = 8.5 #930

Closed
wants to merge 2 commits into from

Conversation

deborshi-web
Copy link

I have update the pyproject.toml and set fail-under = 8.5

i have update the pyproject.toml and set fail-under = 8.5
update the pyproject.toml and set fail-under = 8.5
@fatchat
Copy link
Contributor

fatchat commented Jan 21, 2025

Could you tell me what this does and why you think the change is good to have / necessary?

@deborshi-web
Copy link
Author

deborshi-web commented Jan 21, 2025

@fatchat Ishankoradia raised an issue it is called improve repo's pylint score #867 and instructed to set fail-under = 8.5 under the pylint section. so i set and pull request

@deborshi-web
Copy link
Author

@fatchat Pyproject.toml stores configuration details. am i correct ?

@fatchat
Copy link
Contributor

fatchat commented Jan 26, 2025

ok... but did you also check the pylint score? what is the current score, is it above 8.5

@deborshi-web
Copy link
Author

deborshi-web commented Jan 26, 2025

current score is below 8.5

[tool.pylint.messages_control]
max-line-length = 200
fail-under = 6.5 <-- Here it is, it says 6.5

@fatchat
Copy link
Contributor

fatchat commented Jan 26, 2025

That's not the score, that is a limit below which the score cannot fall in order for the CI/CD to pass

@deborshi-web
Copy link
Author

@fatchat can you please tell me where can i make sure whether score is above 8.5

@fatchat
Copy link
Contributor

fatchat commented Jan 27, 2025

@deborshi-web i think with some googling / chatgpt you will be able to figure it out

@fatchat
Copy link
Contributor

fatchat commented Feb 1, 2025

closing due to inactivity

@fatchat fatchat closed this Feb 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants