Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix home font responsivenes #320

Merged
merged 3 commits into from
Feb 11, 2025
Merged

Fix home font responsivenes #320

merged 3 commits into from
Feb 11, 2025

Conversation

DinneK
Copy link
Contributor

@DinneK DinneK commented Feb 10, 2025

module-name: Refactor home page language

Problem

  • Main metrics explanation was too verbose.
  • Font size did not respond to screen size.

Solution

  • Shortened language to only reflect Metrics. Code.json will be added to either a FAQ page or glossary.
  • Font size enlarged to 1.3rem.

Result

  • Home page is not as busy and only reflects current application.
  • Font changes dynamically dependent on screen size.

Test Plan

Checked in browser with adaptive screen sizes.

DinneK added 3 commits February 9, 2025 16:35
@DinneK
Fix navigation
d3785a9 
Signed-off-by: Dinne Kopelevich <[email protected]>
@DinneK
Delete extra line
a07ca9a 
Signed-off-by: Dinne Kopelevich <[email protected]>
@DinneK
Refactor main page
7822582 
Signed-off-by: Dinne Kopelevich <[email protected]>
@DinneK DinneK added enhancement New feature or request front-end javascript Pull requests that update Javascript code metrics labels Feb 10, 2025
@DinneK DinneK self-assigned this Feb 10, 2025
github-actions[bot]
github-actions bot reviewed Feb 10, 2025
View reviewed changes
@DinneK DinneK merged commit 7822582 into dev Feb 11, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@IsaacMilarky IsaacMilarky Awaiting requested review from IsaacMilarky

@natalialuzuriaga natalialuzuriaga Awaiting requested review from natalialuzuriaga

@sachin-panayil sachin-panayil Awaiting requested review from sachin-panayil

Assignees

@DinneK DinneK

Labels
enhancement New feature or request front-end javascript Pull requests that update Javascript code metrics
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@DinneK