Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix menu responsiveness #318

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Fix menu responsiveness #318

wants to merge 3 commits into from
+100 −186

Conversation

DinneK
Copy link
Contributor

@DinneK DinneK commented Feb 9, 2025

module-name: Create menu responsiveness

Problem

  • Menu disappears on screens smaller than 768px
  • Burger menu is not accessible or easy to tab through. Burger menu should only appear on smaller screen such as mobile and tablet.

Solution

  • Changed logic in nav.js to change with screen size. Regular horizontal menu appears on screen larger than 768px.
  • Hamburger menu appears on smaller screens.
  • Deleted extraneous code within style.css
  • Modified nav.liquid

Result

  • Menu works as intended. Complies with 508 standards. Complies with USWDS standards.

Test Plan

  • Tested in browser

DinneK added 3 commits January 30, 2025 18:50
@DinneK
Fix Metrics Title
b4c10cf 
Signed-off-by: Dinne Kopelevich <[email protected]>
@DinneK
Fix navigation
d3785a9 
Signed-off-by: Dinne Kopelevich <[email protected]>
@DinneK
Delete extra line
a07ca9a 
Signed-off-by: Dinne Kopelevich <[email protected]>
@DinneK DinneK added front-end javascript Pull requests that update Javascript code metrics labels Feb 9, 2025
@DinneK DinneK self-assigned this Feb 9, 2025
github-actions[bot]
github-actions bot reviewed Feb 9, 2025
View reviewed changes
decause-gov
decause-gov approved these changes Feb 27, 2025
View reviewed changes
Copy link
Contributor

@decause-gov decause-gov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have not tested this, but the checks are all green, so it in theory could have been merged? There are conflicts now, so prolly wanna pull the latest, but after that, LGTM +1 🚢

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@decause-gov decause-gov decause-gov approved these changes

@IsaacMilarky IsaacMilarky Awaiting requested review from IsaacMilarky

@natalialuzuriaga natalialuzuriaga Awaiting requested review from natalialuzuriaga

@sachin-panayil sachin-panayil Awaiting requested review from sachin-panayil

Assignees

@DinneK DinneK

Labels
front-end javascript Pull requests that update Javascript code metrics
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DinneK @decause-gov