2466: STI-ify PayrollAccounts #473
Open
+76
−59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
allthesignals
commented
Feb 27, 2025
Comment on lines
+2
to
+10
| def self.sti_name | ||
| # "PayrollAccount::Pinwheel" => "pinwheel" | ||
| name.demodulize.downcase | ||
| end | ||
|
|
||
| def self.sti_class_for(type_name) | ||
| # "pinwheel" => PayrollAccount::Pinwheel | ||
| PayrollAccount.const_get(type_name.capitalize) | ||
| end |
There was a problem hiding this comment.
Not sure this is necessary? Since the behavior is default
There was a problem hiding this comment.
I guess we can try removing it? It probably is not necessary if we are ok with the "type" column having "payroll_account/pinwheel" as the value rather than just "pinwheel".
# Conflicts: # app/app/models/payroll_account.rb # app/db/schema.rb # docs/app/rendered/database-schema.pdf
allthesignals
force-pushed
the
wmg/2466-sti
branch
from
43d259c to
f8de0ab
Compare
tdooner
approved these changes
Feb 27, 2025
Comment on lines
+2
to
+10
| def self.sti_name | ||
| # "PayrollAccount::Pinwheel" => "pinwheel" | ||
| name.demodulize.downcase | ||
| end | ||
|
|
||
| def self.sti_class_for(type_name) | ||
| # "pinwheel" => PayrollAccount::Pinwheel | ||
| PayrollAccount.const_get(type_name.capitalize) | ||
| end |
There was a problem hiding this comment.
I guess we can try removing it? It probably is not necessary if we are ok with the "type" column having "payroll_account/pinwheel" as the value rather than just "pinwheel".
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
Resolves FFS-2466.
Changes
Convert PayrollAccounts to an STI with a Pinwheel subclass.
Context for reviewers
Acceptance testing
:alert: Deploy block! @ffs-eng I just merged PR [#123] and will be doing acceptance testing in demo - please don't deploy until I'm finished!)