FFS-2466: Rename cbv_flow identifier column for clarity #472
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tdooner
approved these changes
Feb 26, 2025
| @@ -1,5 +1,5 @@ | |||
| class AddEndUserIdColumnToCbvFlows < ActiveRecord::Migration[7.1] | |||
| def change | |||
| add_column :cbv_flows, :pinwheel_end_user_id, :uuid, default: 'gen_random_uuid()', null: false | |||
| add_column :cbv_flows, :end_user_id, :uuid, default: 'gen_random_uuid()', null: false | |||
There was a problem hiding this comment.
In general, not a good idea to edit migrations that have already been run, since this would break the future migration.
There was a problem hiding this comment.
Oof, that's a mistake. My bad, thanks for catching
# Conflicts: # app/db/schema.rb # docs/app/rendered/database-schema.pdf
allthesignals
force-pushed
the
wmg/2466-rename-pinwheel_end_user_id
branch
from
0bd5be0 to
91963b6
Compare
# Conflicts: # app/db/schema.rb # docs/app/rendered/database-schema.pdf
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
Resolves FFS-2466.
Changes
Renames cbv_flow identifier column so that it's clear it can be used simply to identify the flow
Context for reviewers
It was confusing how this column was named. We use this column to identify which flow the incoming aggregator account is meant for.
Acceptance testing
:alert: Deploy block! @ffs-eng I just merged PR [#123] and will be doing acceptance testing in demo - please don't deploy until I'm finished!)