Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FFS-2466: Rename PinwheelAccount model to PayrollAccount #470

Merged
merged 3 commits into from
Feb 27, 2025
Merged

FFS-2466: Rename PinwheelAccount model to PayrollAccount #470

merged 3 commits into from
Feb 27, 2025

Conversation

allthesignals
Copy link
Contributor

@allthesignals allthesignals commented Feb 25, 2025 •
edited
Loading

Ticket

Resolves FFS-2466.

Changes

In preparation for making this more generic we should rename this model to reflect that.

Context for reviewers

We still call the table pinwheel_accounts but I can add a migration to rename it if it helps...

Acceptance testing

  • No acceptance testing needed
    • This change will not affect the user experience (bugfix, dependency updates, etc.)
  • Acceptance testing prior to merge
    • This change can be verified visually via screenshots attached below or by sending a link to a local development environment to the acceptance tester
    • Acceptance testing should be done by design for visual changes, product for behavior/logic changes, or both for changes that impact both.
  • Acceptance testing after merge
    • This change is hard to test locally, so we'll test it in the demo environment (deployed automatically after merge.)
    • Make sure to notify the team once this PR is merged so we don't inadvertently deploy the unaccepted change to production. (e.g. :alert: Deploy block! @ffs-eng I just merged PR [#123] and will be doing acceptance testing in demo - please don't deploy until I'm finished!)

@allthesignals allthesignals marked this pull request as ready for review February 26, 2025 20:47
@allthesignals allthesignals changed the title FFS-2466: Sketching PayrollAccount STI approach FFS-2466: Rename PinwheelAccount model to PayrollAccount Feb 26, 2025
tdooner
tdooner approved these changes Feb 26, 2025
View reviewed changes
app/app/models/payroll_account.rb Outdated
@@ -1,4 +1,6 @@
class PinwheelAccount < ApplicationRecord
class PayrollAccount < ApplicationRecord
self.table_name = "pinwheel_accounts"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmmm, we should rename the table at some point as well to prevent confusion.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll just add a migration for it here.

@allthesignals allthesignals merged commit 1045804 into main Feb 27, 2025
15 checks passed
tdooner added a commit that referenced this pull request Feb 27, 2025
@tdooner
Merge remote-tracking branch 'origin/main' into td/ffs-2463-remove-in…
0aeb7f5 
…dexing-fields-from-cbvflow

* origin/main:
  Rename cbv_flow identifier column for clarity (#472)
  FFS-2466: Rename PinwheelAccount model to PayrollAccount (#470)
tdooner added a commit that referenced this pull request Feb 27, 2025
@tdooner
Merge remote-tracking branch 'origin/main' into td/ffs-2463-remove-in…
1de7cf6 
…dexing-fields-from-cbvflow

* origin/main:
  Rename cbv_flow identifier column for clarity (#472)
  FFS-2466: Rename PinwheelAccount model to PayrollAccount (#470)
tdooner added a commit that referenced this pull request Feb 27, 2025
@tdooner
Merge remote-tracking branch 'origin/main' into td/ffs-2463-remove-in…
438f590 
…dexing-fields-from-cbvflow

* origin/main:
  Rename cbv_flow identifier column for clarity (#472)
  FFS-2466: Rename PinwheelAccount model to PayrollAccount (#470)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tdooner tdooner tdooner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@allthesignals @tdooner