Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FFS-2397-2: use remote_ip instead of ip #466

Merged
merged 1 commit into from
Feb 21, 2025
Merged

FFS-2397-2: use remote_ip instead of ip #466

merged 1 commit into from
Feb 21, 2025

Conversation

millerti
Copy link
Contributor

@millerti millerti commented Feb 21, 2025

FFS-2397

Changes

In acceptance testing, we found that the user profile created did not ALWAYS match the location of the user creating the event. This is an experimental fix because I can't figure out how to test it locally... I need it to be running in demo so that request.ip and request.remote_ip resolve to something other than 127.0.0.1.

Acceptance testing

  • No acceptance testing needed
    • This change will not affect the user experience (bugfix, dependency updates, etc.)
  • Acceptance testing prior to merge
    • This change can be verified visually via screenshots attached below or by sending a link to a local development environment to the acceptance tester
    • Acceptance testing should be done by design for visual changes, product for behavior/logic changes, or both for changes that impact both.
  • Acceptance testing after merge
    • This change is hard to test locally, so we'll test it in the demo environment (deployed automatically after merge.)
    • Make sure to notify the team once this PR is merged so we don't inadvertently deploy the unaccepted change to production. (e.g. :alert: Deploy block! @ffs-eng I just merged PR [#123] and will be doing acceptance testing in demo - please don't deploy until I'm finished!)

@millerti millerti marked this pull request as ready for review February 21, 2025 19:49
@millerti millerti changed the title experimental: use remote_ip instead of ip FFS-2397-2: use remote_ip instead of ip Feb 21, 2025
@millerti millerti merged commit bbe22b2 into main Feb 21, 2025
15 checks passed
millerti added a commit that referenced this pull request Feb 21, 2025
@millerti millerti deleted the TIMO/2397-2 branch February 21, 2025 22:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants