Fix flaky rake tests by always loading Rake tasks once #439
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
No ticket - flaky tests.
Changes
Context for reviewers
If
Rails.application.load_tasks
is called multiple times, than anyinvocation of a Rake task will actually happen multiple times. This is
problematic for non-idempotent Rake tasks (like
users:promote_to_service_account
).Let's prevent this issue by just loading the tasks in the
"rails_helper.rb" file so they're always available.
Acceptance testing
:alert: Deploy block! @ffs-eng I just merged PR [#123] and will be doing acceptance testing in demo - please don't deploy until I'm finished!
)