FFS-2291

millerti · 2025-01-08T22:13:11Z

Changes

Events now file to Mixpanel
Events still file to NewRelic
Some events have new names in Mixpanel per this map

Testing

Add the MIXPANEL_TOKEN from 1Password into your env.development.local file
Satisfy yourself that going through the workflow logs events to both Mixpanel and NewRelic
Convince yourself that only the new Mixpanel event names are being logged to Mixpanel
Convince yourself that only the old NewRelic event names are being logged to NewRelic
Verify that the NewRelic dashboards still appear to work
Convince yourself that, when a new invitation_id is present, Mixpanel identifies events for that as being done by a new user

Acceptance testing

No acceptance testing needed
- This change will not affect the user experience (bugfix, dependency updates, etc.)
Acceptance testing prior to merge
- This change can be verified visually via screenshots attached below or by sending a link to a local development environment to the acceptance tester
- Acceptance testing should be done by design for visual changes, product for behavior/logic changes, or both for changes that impact both.
Acceptance testing after merge
- This change is hard to test locally, so we'll test it in the demo environment (deployed automatically after merge.)
- Make sure to notify the team once this PR is merged so we don't inadvertently deploy the unaccepted change to production. (e.g. :alert: Deploy block! @ffs-eng I just merged PR [#123] and will be doing acceptance testing in demo - please don't deploy until I'm finished!)

This adds a simple MixpanelEventTracker module, comparable to the NewRelic one.

Co-authored-by: snyk-bot <[email protected]>

Snyk has created this PR to upgrade @uswds/uswds from 3.9.0 to 3.10.0. See this package in npm: @uswds/uswds See this project in Snyk: https://app.snyk.io/org/ospo/project/a94f26c7-ed40-4004-a636-d3b13c37de47?utm_source=github&utm_medium=referral&page=upgrade-pr Co-authored-by: snyk-bot <[email protected]>

Snyk has created this PR to upgrade sass from 1.80.6 to 1.81.0. See this package in npm: sass See this project in Snyk: https://app.snyk.io/org/ospo/project/a94f26c7-ed40-4004-a636-d3b13c37de47?utm_source=github&utm_medium=referral&page=upgrade-pr Co-authored-by: snyk-bot <[email protected]>

* Bump vulnerabilities * Version bump nanoid * Bump as transient * Revert "Bump vulnerabilities" This reverts commit 983020d. # Conflicts: # app/package-lock.json

Co-authored-by: Tom Dooner <[email protected]>

* Redirect if portal is disabled * Default staff protal to true * Add test * Revert schema * Disable and move copy to dictionary * Move to base controller * Update tests to reflect disabled portal * Enable portals for their respective test suites * Avoid should * Update app/spec/controllers/caseworker/entries_controller_spec.rb Co-authored-by: Tom Dooner <[email protected]> * Better assertion --------- Co-authored-by: Tom Dooner <[email protected]>

Co-authored-by: Tom Dooner <[email protected]>

Co-authored-by: snyk-bot <[email protected]>

* Make the /api/pinwheel/user_action endpoint generic so it can receive an "eventName" and arbitrary "attributes" for an event. This will be used in subsequent commits for Pinwheel modal events. * Create new event, `ApplicantSelectedEmployerOrPlatformItem`, to replace events `ApplicantSelectedPopularPayrollPlatform` and `ApplicantSelectedPopularAppEmployer`. A unified event prevents the javascript from having to know which event to send, and will also make funnel analysis and future maintenance easier. * Add an attribute `is_default_option` to the new event so we can tell apart clicks on the 12 default items from clicks on search results. * Add the `name` attribute to also be present on search results (as it was previously only present on the default options) * Add tests for user action API

These events cover most of what we're hoping to instrument for future Pinwheel sessions. In the order a user may experience them: 1. `PinwheelShowProviderConfirmationPage` - sent when a provider confirmation screen is shown (e.g. "Amazon" showing multiple platforms like A to Z and ADP) 2. `PinwheelShowLoginPage` - sent when the first screen of a login is shown (whether it's employer disambiguation, username/password, or other input required by user) 3. `PinwheelAttemptLogin` - sent when the user attempts login (sent only once on the first screen even if there are subsequent screens for MFA or other employer-specific questions). Unfortunately, there are no Pinwheel events on the subsequent login pages. 4. `PinwheelError` - sent when an error occurs, likely an incorrect login or MFA code, but also a system error. 5. `PinwheelSuccess` - sent when the login completes. If the user doesn't follow the intended path through the modal, they may trigger: 6. `PinwheelShowDefaultProviderSearch` - sent when the user deselects the employer or platform and returns to the beginning of the pinwheel modal 7. `PinwheelAttemptClose` - shown when the user clicks the "X" in the modal, before confirming the closure 8. `PinwheelCloseModal` - shown when the modal actually closes

…O/2291

…nd include mixpanel tests

…s in mixpanel

…ated

tdooner

No blockers but some suggestions for future work that maybe we could add as tech debt tickets later.

app/app/controllers/api/pinwheel_controller.rb

app/lib/generic_event_tracker.rb

app/lib/new_relic_event_tracker.rb

app/lib/mixpanel_event_tracker.rb

app/spec/controllers/cbv/summaries_controller_spec.rb

app/spec/lib/new_relic_event_tracker_spec.rb

allthesignals · 2025-01-24T18:21:42Z

app/app/controllers/cbv/base_controller.rb

+      event_logger.track("CbvPageView", request, {
+        cbv_flow_id: @cbv_flow.id,
+        invitation_id: @cbv_flow.cbv_flow_invitation_id,
+        site_id: @cbv_flow.site_id,
+        path: request.path


Note, I believe this is breaking some views, specifically expired links.

The error message is being swallowed and the user is redirected to a flash error message, which is why we didn't catch it.

tdooner and others added 30 commits December 17, 2024 10:57

Add MixpanelEventTracker proof of concept

200241d

This adds a simple MixpanelEventTracker module, comparable to the NewRelic one.

Add MIXPANEL_TOKEN environment variable

ecb1e31

FFS-2175 - Updating Puma webserver to preload the app (#391)

7e8550a

[Snyk] Upgrade postcss from 8.4.48 to 8.4.49 (#395)

872721b

Co-authored-by: snyk-bot <[email protected]>

Bump vulnerabilities (#396)

3387d3e

* Bump vulnerabilities * Version bump nanoid * Bump as transient * Revert "Bump vulnerabilities" This reverts commit 983020d. # Conflicts: # app/package-lock.json

FFS-2175: Installing skylight on dev (#397)

35a1afe

Co-authored-by: Tom Dooner <[email protected]>

FFS-2175: Installing skylight on dev (#398)

0c0af8f

Co-authored-by: Tom Dooner <[email protected]>

FFS-2175: Adding DB query to /health endpoint (#401)

8083204

Co-authored-by: Tom Dooner <[email protected]>

FFS-2175: Removing Skylight from the project (#402)

e4c374b

[Snyk] Upgrade dotenv from 16.4.5 to 16.4.7 (#405)

e105b6e

Co-authored-by: snyk-bot <[email protected]>

[Snyk] Upgrade webpack from 5.96.1 to 5.97.0 (#404)

8805d61

Co-authored-by: snyk-bot <[email protected]>

[Snyk] Upgrade sass from 1.81.0 to 1.82.0 (#407)

7453a70

Co-authored-by: snyk-bot <[email protected]>

Merge branch 'TIMO/2291' of github.com:DSACMS/iv-cbv-payroll into TIM…

b9cd70f

…O/2291

rudimentary tracking for both mixpanel and newrelic events

aa43d54

minor bug fixes

87c9553

generalized tracking, added easy multi event tracking

5eb528e

switch almost all event tracking to generic tracker

771e074

bugfixes for email event workflows, pinwheel event corrections

53c161b

minor corrections

99cc29b

linting and minor fixes

1107a09

smaller changes to support easier unit testing; pinwheel specs pass a…

3961970

…nd include mixpanel tests

fixed NR events, added Mixpanel events

f154940

Fixed NR events, added Mixpanel events to spec

f9b2ce9

Fixed NR event test, added Mixpanel test

667ac7f

mostly fixed, still one problem here

2dfbeb3

millerti added 15 commits January 13, 2025 15:47

fixed and added Mixpanel tests

bd37338

fixed and added Mixpanel event tests

5f46968

fixed and added Mixpanel event test

ee0a91e

still one problem here

1a54de0

fixed gnarly issue with spec getting multiple event trackers

51d30b6

bug squashing

0024a25

fixed but where CbvInvitationService had no access to event_logger

5dea6f0

testing trackers themselves; also trying to distinguish invitation ID…

32b8774

…s in mixpanel

linter

79e1ce9

Merge branch 'main' into TIMO/2291

3c030c8

fixes to identity detection

85c0962

added new name for ApplicantCreatedPinwheelAccount/PinwheelAccountCre…

7186c84

…ated

rubocop fixes and one event name fix

608c4f3

rubocop fix

bf249c6

bump linux-libc-dev to fix vuln

e07dc76

millerti changed the title ~~Timo/2291~~ FFS-2291 - Implement Mixpanel events Jan 17, 2025

millerti marked this pull request as ready for review January 17, 2025 21:39

tdooner approved these changes Jan 18, 2025

View reviewed changes

millerti added 4 commits January 22, 2025 12:36

CR responses

7a984d5

Merge branch 'main' into TIMO/2291

6f94c78

Merge branch 'main' into TIMO/2291

cdf408e

Merge branch 'main' into TIMO/2291

6b2d548

millerti merged commit 64654c5 into main Jan 22, 2025
20 checks passed

allthesignals reviewed Jan 24, 2025

View reviewed changes

millerti deleted the TIMO/2291 branch February 21, 2025 22:13

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

FFS-2291 - Implement Mixpanel events #412

FFS-2291 - Implement Mixpanel events #412

millerti commented Jan 8, 2025 •

edited

Loading

tdooner left a comment

allthesignals Jan 24, 2025

FFS-2291 - Implement Mixpanel events #412

FFS-2291 - Implement Mixpanel events #412

Conversation

millerti commented Jan 8, 2025 • edited Loading

FFS-2291

Changes

Testing

Acceptance testing

tdooner left a comment

Choose a reason for hiding this comment

allthesignals Jan 24, 2025

Choose a reason for hiding this comment

millerti commented Jan 8, 2025 •

edited

Loading