Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FFS-2175: Adding DB query to /health endpoint #401

Merged
merged 7 commits into from
Dec 19, 2024

Conversation

GeorgeCodes19
Copy link
Contributor

@GeorgeCodes19 GeorgeCodes19 commented Dec 18, 2024

Ticket

Relates to FFS-2175.

Changes

Context for reviewers

Acceptance testing

  • No acceptance testing needed
    • This change will not affect the user experience (bugfix, dependency updates, etc.)
  • Acceptance testing prior to merge
    • This change can be verified visually via screenshots attached below or by sending a link to a local development environment to the acceptance tester
    • Acceptance testing should be done by design for visual changes, product for behavior/logic changes, or both for changes that impact both.
  • Acceptance testing after merge
    • This change is hard to test locally, so we'll test it in the demo environment (deployed automatically after merge.)
    • Make sure to notify the team once this PR is merged so we don't inadvertently deploy the unaccepted change to production. (e.g. :alert: Deploy block! @ffs-eng I just merged PR [#123] and will be doing acceptance testing in demo - please don't deploy until I'm finished!)

@GeorgeCodes19 GeorgeCodes19 changed the title FFS-2175: Installing skylight on dev FFS-2175: Adding DB query to /health endpoint Dec 18, 2024
Copy link
Contributor

@tdooner tdooner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, that'll do it!

(Just for future record: it's generally not a good idea to test other systems in a healthcheck because if there's a database outage, then your web servers would all go down simultaneously. So, we can remove this in the future when we have enough traffic that we don't need to keep the database connection alive.)

@GeorgeCodes19 GeorgeCodes19 merged commit 69a0315 into main Dec 19, 2024
14 checks passed
@GeorgeCodes19 GeorgeCodes19 deleted the george/ffs-2175-skylight branch December 19, 2024 02:58
YvetteWhiteUSDS added a commit that referenced this pull request Jan 3, 2025
* Added controller to add javascript on send button.

* FFS-2175: Adding DB query to /health endpoint (#401)

Co-authored-by: Tom Dooner <[email protected]>

* FFS-2175: Removing Skylight from the project (#402)

* Wire up Caseworker Invitation JS controller

Co-Authored-By: Yvette White <[email protected]>

* Create `uswds_form_with` helper to use Turbo on invitation page

Co-Authored-By: Yvette White <[email protected]>

---------

Co-authored-by: George Byers <[email protected]>
Co-authored-by: Tom Dooner <[email protected]>
Co-authored-by: Yvette White <[email protected]>
millerti pushed a commit that referenced this pull request Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants