Demo draft #4
Merged
Demo draft #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tdooner
approved these changes
Apr 24, 2024
| <form data-controller="providers" action="/providers/confirm" method="get"> | ||
| <label class="usa-label" for="employer">Search for an employer</label> | ||
| <div class="usa-combo-box margin-bottom-3" data-action="input->providers#search"> | ||
| <select class="usa-select" name="employer" id="employer" data-providers-target="options" data-action="change->providers#select"> |
There was a problem hiding this comment.
Interesting. Did you figure all this out this morning? Nice. I guess this prevents us from needing to bring in React on the frontend, so that's kind of neat.
There was a problem hiding this comment.
Yeah! The Hotwire stuff is kinda nice. It sorta plays well with the USWDS stuff? Thanks to event bubbling. We may start to push up against some UX jank, though.
|
Looks good, but you will need to delete the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can just demo this and fixup later!