Internalize and localize #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tdooner
approved these changes
May 14, 2024
config/locales/en.yml
Outdated
| welcome: Welcome to Verify.gov | ||
| description: This website can help you get approved for your benefits. | ||
| subheader: Get started here by requesting a link from your caseworker. | ||
| cbv: |
There was a problem hiding this comment.
let's align these with the name of the controller, i.e. cbv_flows rather than cbv.
That will allow us to do, in the controller, relative keys as described here: https://edgeguides.rubyonrails.org/i18n.html#lazy-lookup
|
Maybe have to skip the "missing keys" for now |
|
@tdooner merging this then going to make. quick follow up PR to enable rubocop and detect hard-coded strings |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Internationalizes and localizes hard-coded strings.